I backported this so we can use util::Result somewhere, but i'm not convinced of its usefulness for this particular use case. It is not less verbose.

The real reason I need util::Result is because it will be used in assumeutxo code (core#27862)

PiRK edited the summary of this revision. (Show Details)Dec 15 2023, 09:43

Harbormaster completed remote builds in B25974: Diff 43634.Dec 15 2023, 10:02

Fabien accepted this revision.Dec 15 2023, 10:10

This revision is now accepted and ready to land.Dec 15 2023, 10:10

Closed by commit rABCf3139ddbac7d: refactor: Replace std::optional<bilingual_str> with util::Result (authored by Ryan Ofsky <ryan@ofsky.org>, committed by PiRK). · Explain WhyDec 15 2023, 11:34

This revision was automatically updated to reflect the committed changes.

PiRK added a commit: rABCf3139ddbac7d: refactor: Replace std::optional<bilingual_str> with util::Result.

Revision Contents
Changeset List

Path

Size

src/

13 lines

27 lines

16 lines

9 lines

22 lines

Diff 43637

View Options

src/addrdb.h

View Options

src/addrdb.cpp

View Options

src/init.cpp

View Options

src/txdb.h

View Options

refactor: Replace std::optional<bilingual_str> with util::ResultClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 43637

src/addrdb.h

src/addrdb.cpp

src/init.cpp

src/txdb.h

src/txdb.cpp

refactor: Replace std::optional<bilingual_str> with util::Result
ClosedPublic
Actions

Revision Contents
Changeset List