Paths

Table of Contentst

Differential D17736

refactor: Reduce number of SanityChecks return values and return util::Result
ClosedPublic
Actions

Authored by PiRK on Mon, Mar 3, 14:38.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rABC4b9853aa63ac: refactor: Reduce number of SanityChecks return values and return util::Result

Summary

This is a partial backport of core#25308
https://github.com/bitcoin/bitcoin/pull/25308/commits/6db6552377ad6316626b3ab8605a98f96f22c3d2

with changes from core#25977 applied

Previous work related to core#25308 and core#25977 (D14614 and D14992) didn't include these changes because of out-of-order backports

Depends on D17723

Test Plan

ninja all check-all

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

PiRK created this revision.Mon, Mar 3, 14:38

Herald added a reviewer: Restricted Project. · View Herald TranscriptMon, Mar 3, 14:38

PiRK requested review of this revision.Mon, Mar 3, 14:38

teamcity edited the summary of this revision. (Show Details)Mon, Mar 3, 14:39

Harbormaster completed remote builds in B32568: Diff 52884.Mon, Mar 3, 14:52

Fabien accepted this revision.Mon, Mar 3, 15:27

This revision is now accepted and ready to land.Mon, Mar 3, 15:27

Closed by commit rABC4b9853aa63ac: refactor: Reduce number of SanityChecks return values and return util::Result (authored by Ryan Ofsky <ryan@ofsky.org>, committed by PiRK). · Explain WhyMon, Mar 3, 16:11

This revision was automatically updated to reflect the committed changes.

PiRK added a commit: rABC4b9853aa63ac: refactor: Reduce number of SanityChecks return values and return util::Result.

Revision Contents
Changeset List

Path

Size

src/

bitcoin-chainstate.cpp

2 lines

init.cpp

20 lines

kernel/

checks.h

10 lines

checks.cpp

13 lines

Diff 52887

View Options

src/bitcoin-chainstate.cpp

View Options

src/init.cpp

View Options

src/kernel/checks.h

View Options

refactor: Reduce number of SanityChecks return values and return util::ResultClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 52887

src/bitcoin-chainstate.cpp

src/init.cpp

src/kernel/checks.h

src/kernel/checks.cpp

refactor: Reduce number of SanityChecks return values and return util::Result
ClosedPublic
Actions

Revision Contents
Changeset List