[Chronik] Add `Script::put_pushdata` and `Script::put_slp_pushdata`
ClosedPublic
Actions

Authored by tobias_ruck on Dec 19 2023, 23:09.

Details

Reviewers

Fabien
PiRK

Group Reviewers

Restricted Project

Commits

rABC9206bd9762fc: [Chronik] Add `Script::put_pushdata` and `Script::put_slp_pushdata`

Summary

This is helpful when building SLP/ALP OP_RETURN scripts.

Test Plan

cargo test -p bitcoinsuite-core

Diff Detail

Repository

rABC Bitcoin ABC

Branch

chronik-bitcoinsuite-put_pushdata

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 26003
Build 51580: Build Diff	build-chronik · chronik-client-integration-tests
Build 51579: arc lint + arc unit

Event Timeline

tobias_ruck created this revision.Dec 19 2023, 23:09

Herald added a reviewer: Restricted Project. · View Herald TranscriptDec 19 2023, 23:09

tobias_ruck requested review of this revision.Dec 19 2023, 23:09

Harbormaster completed remote builds in B25999: Diff 43673.Dec 19 2023, 23:16

Build Bitcoin ABC Diffs / Diff Testing (chronik-client-integration-tests) failed.

Tail of the build log:

48 packages are looking for funding
  run `npm fund` for details

1 moderate severity vulnerability

To address all issues (including breaking changes), run:
  npm audit fix --force

Run `npm audit` for details.

> chronik-client@0.9.0 integration-tests
> mocha -j1 -r ts-node/register test/integration/*.ts --reporter mocha-junit-reporter --reporter-options mochaFile=test_results/chronik-client-integration-tests-junit.xml --reporter-options testsuitesTitle=Chronik Client Integration Tests --reporter-options rootSuiteTitle=Chronik Client

Starting test_runner
Test runner started
2023-12-19T23:15:34.125000Z TestFramework (INFO): Initializing test directory /work/abc-ci-builds/chronik-client-integration-tests/test/tmp/test_runner_₿₵_🏃_20231219_231533/setup_scripts/chronik-client_blockchain_info_0
Setting chronik url to  http://127.0.0.1:30001
2023-12-19T23:15:36.084000Z TestFramework (INFO): Step 1: Mine 10 more blocks
2023-12-19T23:15:36.099000Z TestFramework (INFO): Received a stop message, exiting
2023-12-19T23:15:36.150000Z TestFramework (INFO): Stopping nodes
2023-12-19T23:15:36.555000Z TestFramework (INFO): Cleaning up /work/abc-ci-builds/chronik-client-integration-tests/test/tmp/test_runner_₿₵_🏃_20231219_231533/setup_scripts/chronik-client_blockchain_info_0 on exit
2023-12-19T23:15:36.555000Z TestFramework (INFO): Tests successful
Running Unit Tests for Test Framework Modules
[1msetup_scripts/chronik-client_blockchain_info.py[0m started
[1msetup_scripts/chronik-client_blockchain_info.py[0m passed, Duration: 3 s
[1m
TEST                                            | STATUS    | DURATION

[0m[0;32msetup_scripts/chronik-client_blockchain_info.py | ✓ Passed  | 3 s
[0m[1m
ALL                                             | ✓ Passed  | 3 s (accumulated) 
[0mRuntime: 3 s

-----------------------|---------|----------|---------|---------|-----------------------------------
File                   | % Stmts | % Branch | % Funcs | % Lines | Uncovered Line #s                 
-----------------------|---------|----------|---------|---------|-----------------------------------
All files              |    5.36 |     0.63 |    1.47 |    5.35 |                                   
 chronik-client        |     100 |      100 |     100 |     100 |                                   
  index.ts             |     100 |      100 |     100 |     100 |                                   
 chronik-client/proto  |     4.9 |     0.67 |    1.72 |    4.89 |                                   
  chronik.ts           |    5.44 |     0.84 |    1.81 |    5.42 | ...,3978-3985,3990-4027,4031-4036 
  chronikNode.ts       |    4.15 |     0.45 |    1.59 |    4.17 | ...,2682-2729,2740-2804,2808-2813 
 chronik-client/src    |    8.59 |        0 |       0 |    8.55 |                                   
  ChronikClient.ts     |    4.19 |        0 |       0 |    4.24 | 29-159,174-218,296-699            
  ChronikClientNode.ts |      40 |      100 |       0 |      40 | 23-42                             
  failoverProxy.ts     |    4.04 |        0 |       0 |    4.16 | 27-299                            
  hex.ts               |   31.57 |        0 |       0 |   33.33 | 30-34,38-42,46-59,63-65           
-----------------------|---------|----------|---------|---------|-----------------------------------

##teamcity[blockOpened name='Code Coverage Summary']
##teamcity[buildStatisticValue key='CodeCoverageAbsBCovered' value='156']
##teamcity[buildStatisticValue key='CodeCoverageAbsBTotal' value='2906']
##teamcity[buildStatisticValue key='CodeCoverageAbsRCovered' value='21']
##teamcity[buildStatisticValue key='CodeCoverageAbsRTotal' value='3282']
##teamcity[buildStatisticValue key='CodeCoverageAbsMCovered' value='8']
##teamcity[buildStatisticValue key='CodeCoverageAbsMTotal' value='541']
##teamcity[buildStatisticValue key='CodeCoverageAbsLCovered' value='154']
##teamcity[buildStatisticValue key='CodeCoverageAbsLTotal' value='2878']
##teamcity[blockClosed name='Code Coverage Summary']
Build chronik-client-integration-tests failed with exit code 1

rerun CI

Harbormaster completed remote builds in B26003: Diff 43678.Dec 20 2023, 00:16

tobias_ruck added a child revision: D15012: [Chronik] Add `slp::parse`, with support for SLP GENESIS txs.Dec 20 2023, 00:22

PiRK accepted this revision.Dec 20 2023, 10:31

This revision is now accepted and ready to land.Dec 20 2023, 10:31

tobias_ruck retitled this revision from [Chronik] Add `Script::put_pushdata` and `Script::push_slp_pushdata` to [Chronik] Add `Script::put_pushdata` and `Script::put_slp_pushdata`.Dec 20 2023, 12:29

Closed by commit rABC9206bd9762fc: [Chronik] Add `Script::put_pushdata` and `Script::put_slp_pushdata` (authored by tobias_ruck). · Explain WhyDec 20 2023, 16:25

This revision was automatically updated to reflect the committed changes.

tobias_ruck added a commit: rABC9206bd9762fc: [Chronik] Add `Script::put_pushdata` and `Script::put_slp_pushdata`.