Page MenuHomePhabricator
Differential D15010

[Chronik] Add `TxId::new` and `TxId::hash`
ClosedPublic
Actions

Authored by tobias_ruck on Dec 19 2023, 23:13.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABC3e4a4bb8d4e9: [Chronik] Add `TxId::new` and `TxId::hash`
Summary

Helpers when dealing with txids.

Depends on D15007.

Test Plan

cargo test -p bitcoinsuite-core

Diff Detail

Repository
rABC Bitcoin ABC
Branch
chronik-bitcoinsuite-txid-methods
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 26000
Build 51574: Build Diffbuild-chronik · chronik-client-integration-tests
Build 51573: arc lint + arc unit

Event Timeline

tobias_ruck created this revision.Dec 19 2023, 23:13
Herald added a reviewer: Restricted Project. · View Herald TranscriptDec 19 2023, 23:13
tobias_ruck requested review of this revision.Dec 19 2023, 23:13
Harbormaster completed remote builds in B26000: Diff 43675.Dec 19 2023, 23:32
PiRK added a subscriber: PiRK.Dec 20 2023, 10:45
PiRK added inline comments.
chronik/bitcoinsuite-core/src/tx/txid.rs
51

In D15012 I see that you are using TxId::from. Is this different?

tobias_ruck added inline comments.Dec 20 2023, 11:41
chronik/bitcoinsuite-core/src/tx/txid.rs
51

TxId::from and TxId::new are the same except new can be used in a const context, as in the doctest of new

Fabien accepted this revision.Dec 20 2023, 11:55
This revision is now accepted and ready to land.Dec 20 2023, 11:55
Closed by commit rABC3e4a4bb8d4e9: [Chronik] Add `TxId::new` and `TxId::hash` (authored by tobias_ruck). · Explain WhyDec 20 2023, 16:26
This revision was automatically updated to reflect the committed changes.
tobias_ruck added a commit: rABC3e4a4bb8d4e9: [Chronik] Add `TxId::new` and `TxId::hash`.

Revision Contents
Changeset List

PathSize
chronik/
bitcoinsuite-core/
src/
tx/
15 lines

Diff 43675

View Options

chronik/bitcoinsuite-core/src/tx/txid.rs

Loading...