Page MenuHomePhabricator
Differential D15063

bench: Represents paths with fs::path instead of std::string
ClosedPublic
Actions

Authored by PiRK on Jan 3 2024, 09:51.

Details

Reviewers
bytesofman
Group Reviewers
Restricted Project
Commits
rABCaf2a781f5087: bench: Represents paths with fs::path instead of std::string
Summary

Also uses fs::path quoting in bench printed strings and fixes a
misleading error message.

Originally suggested https://github.com/bitcoin/bitcoin/pull/20744#issuecomment-1022486215

Co-authored-by: Hennadii Stepanov <32963518+hebasto@users.noreply.github.com>

This is a backport of core#24252

Test Plan

ninja bench-bitcoin

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

PiRK created this revision.Jan 3 2024, 09:51
Herald added a reviewer: Restricted Project. · View Herald TranscriptJan 3 2024, 09:51
PiRK requested review of this revision.Jan 3 2024, 09:51
teamcity edited the summary of this revision. (Show Details)Jan 3 2024, 09:51
PiRK added a child revision: D15064: util: Make ArgsManager::GetPathArg more widely usable.Jan 3 2024, 09:53
Harbormaster completed remote builds in B26112: Diff 43838.Jan 3 2024, 10:18
bytesofman accepted this revision.Jan 3 2024, 20:28
bytesofman added a subscriber: bytesofman.
  • builds are good
  • Unless I'm missing something, PR is exactly the same as merged core PR
This revision is now accepted and ready to land.Jan 3 2024, 20:28
Closed by commit rABCaf2a781f5087: bench: Represents paths with fs::path instead of std::string (authored by Ryan Ofsky <ryan@ofsky.org>, committed by PiRK). · Explain WhyJan 4 2024, 14:05
This revision was automatically updated to reflect the committed changes.
PiRK added a commit: rABCaf2a781f5087: bench: Represents paths with fs::path instead of std::string.

Revision Contents
Changeset List

PathSize
src/
bench/
5 lines
11 lines
5 lines

Diff 43875

View Options

src/bench/bench.h

Loading...
View Options

src/bench/bench.cpp

Loading...
View Options

src/bench/bench_bitcoin.cpp

Loading...