[Chronik] Remove an unnecessary copy of CChainParams in chronik::Start
ClosedPublic
Actions

Authored by tobias_ruck on Jan 5 2024, 10:12.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rABCfcc824a72963: [Chronik] Remove an unnecessary copy of CChainParams in chronik::Start

Summary

A previous oversight

Test Plan

ninja

Diff Detail

Repository

rABC Bitcoin ABC

Branch

chronik-remove-chain-params-copy

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 26163
Build 51899: Build Diff	chronik-client-integration-tests · build-chronik
Build 51898: arc lint + arc unit

Event Timeline

tobias_ruck created this revision.Jan 5 2024, 10:12

Herald added a reviewer: Restricted Project. · View Herald TranscriptJan 5 2024, 10:12

tobias_ruck requested review of this revision.Jan 5 2024, 10:12

Good catch

This revision is now accepted and ready to land.Jan 5 2024, 10:15

Harbormaster completed remote builds in B26163: Diff 43916.Jan 5 2024, 10:54

Closed by commit rABCfcc824a72963: [Chronik] Remove an unnecessary copy of CChainParams in chronik::Start (authored by tobias_ruck). · Explain WhyJan 5 2024, 17:32

This revision was automatically updated to reflect the committed changes.

tobias_ruck added a commit: rABCfcc824a72963: [Chronik] Remove an unnecessary copy of CChainParams in chronik::Start.

Revision Contents
Changeset List

Path

Size

chronik/

chronik-cpp/

chronik.cpp

2 lines

Diff 43916

View Options

chronik/chronik-cpp/chronik.cpp

[Chronik] Remove an unnecessary copy of CChainParams in chronik::StartClosedPublicActions