Page MenuHomePhabricator
Differential D15093

refactor: Remove not needed std::max
ClosedPublic
Actions

Authored by PiRK on Jan 5 2024, 14:21.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABCc27c98eac3b7: refactor: Remove not needed std::max
Summary

This is a partial backport of core#24697
https://github.com/bitcoin/bitcoin/pull/24697/commits/fa9284c3e9acec4b44b2560256f27b3d78c753e2

Depends on D15091

Test Plan

ninja all check-all

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

PiRK created this revision.Jan 5 2024, 14:21
Herald added a reviewer: Restricted Project. · View Herald TranscriptJan 5 2024, 14:21
PiRK requested review of this revision.Jan 5 2024, 14:21
teamcity edited the summary of this revision. (Show Details)Jan 5 2024, 14:21
PiRK added a child revision: D15094: Rename addrman time symbols.Jan 5 2024, 14:23
Harbormaster completed remote builds in B26176: Diff 43932.Jan 5 2024, 14:36
Fabien accepted this revision.Jan 5 2024, 15:55
This revision is now accepted and ready to land.Jan 5 2024, 15:55
Fabien added inline comments.Jan 5 2024, 15:55
src/addrman.cpp
124 ↗(On Diff #43932)

note for reviewers: this can go negative with no impact on the fChance output so even it the calculation make no sense the function is fine

Closed by commit rABCc27c98eac3b7: refactor: Remove not needed std::max (authored by MacroFake <falke.marco@gmail.com>, committed by PiRK). · Explain WhyJan 8 2024, 09:03
This revision was automatically updated to reflect the committed changes.
PiRK added a commit: rABCc27c98eac3b7: refactor: Remove not needed std::max.

Revision Contents
Changeset List

PathSize
src/
3 lines

Diff 43969

View Options

src/addrman.cpp

Loading...