Page MenuHomePhabricator

Rename addrman time symbols
ClosedPublic

Authored by PiRK on Jan 5 2024, 14:23.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABC8007a7c80109: Rename addrman time symbols
Summary

scripted diff:

-BEGIN VERIFY SCRIPT-
 ren() { sed -i "s:\<$1\>:$2:g" $(git grep -l "\<$1\>" ./src ./test); }

 ren nLastTry          m_last_try
 ren nLastSuccess      m_last_success
 ren nLastGood         m_last_good
 ren nLastCountAttempt m_last_count_attempt
 ren nTimePenalty      time_penalty
 ren nUpdateInterval   update_interval
 ren fCurrentlyOnline  currently_online
-END VERIFY SCRIPT-

And manually rename the local vars in addrman_tests.cpp

This is a partial backport of core#24697
https://github.com/bitcoin/bitcoin/pull/24697/commits/fa21fc60c292ab947b2200e54201440f16230566

Depends on D15093

Test Plan

ninja all check-all

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

PiRK requested review of this revision.Jan 5 2024, 14:23
PiRK planned changes to this revision.Jan 5 2024, 14:25

the addrman_tests vars are not member vars

PiRK retitled this revision from scripted-diff: Rename addrman time symbols to Rename addrman time symbols.
PiRK edited the summary of this revision. (Show Details)

manually rename the local vars in addrman_tests.cpp

This revision is now accepted and ready to land.Jan 5 2024, 16:00
This revision was automatically updated to reflect the committed changes.