Differential D15108

[Cashtab] Add nav button labels
Changes PlannedPublic
Actions

Authored by emack on Jan 6 2024, 09:59.

Details

Reviewers

bytesofman

Group Reviewers

Restricted Project

Summary

Adding labels to the bottom navigation icons.

Test Plan

npm test
npm start and review navigation labels
npm run extension
open extension and review navigation labels

Diff Detail

Repository

rABC Bitcoin ABC

Branch

navLabels

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 26202
Build 51976: Build Diff	cashtab-tests
Build 51975: arc lint + arc unit

Event Timeline

emack created this revision.Jan 6 2024, 09:59

Herald added a reviewer: Restricted Project. · View Herald TranscriptJan 6 2024, 09:59

emack requested review of this revision.Jan 6 2024, 09:59

Harbormaster completed remote builds in B26202: Diff 43966.Jan 6 2024, 10:04

@bot preview-cashtab

teamcity awarded a token.Jan 8 2024, 10:16

Build Bitcoin ABC Diffs / Diff Testing (preview-cashtab) passed.
Preview is available at http://51.178.130.230:41765 for the next 60 minutes.

Have there been complaints about this?

imo we have room for a good deal of improvement in Cashtab UX but I'm not sure this really helps. We've had these unlabeled for years. Due to the speed, it's relatively straightforward to check the various screens and see what they do.

The labels are probably a slight improvement. However, I think many Cashtab users are using the browser translation feature. Because of the small size and css specifications required to make these presentable, it's likely displaying these labels in any other language will cause more problems than it solves.

@bot preview-cashtab

Build Bitcoin ABC Diffs / Diff Testing (preview-cashtab) passed.
Preview is available at http://51.178.130.230:41430 for the next 60 minutes.

However, I think many Cashtab users are using the browser translation feature. Because of the small size and css specifications required to make these presentable, it's likely displaying these labels in any other language will cause more problems than it solves.

I was worried about that as well, so I tried: using browser translation to french makes the hamburger menu disappear completely

In D15108#339171, @bytesofman wrote:

Have there been complaints about this?

It just occurred to me when I added the etoken icon to the navigation recently, that the number of nav options are increasing and could be confusing given the ambiguity of the etoken icon. But fair point on the translation issue. Will review further and abandon if not worth the ROI.