Paths

Table of Contentst

Differential D15124

Add bitdeque, an std::deque<bool> analogue that does bit packing.
ClosedPublic
Actions

Authored by PiRK on Jan 10 2024, 08:42.

Tags

None

Subscribers

Details

Reviewers

Group Reviewers

Restricted Project

Commits

rABC6040be892224: Add bitdeque, an std::deque<bool> analogue that does bit packing.

Summary

This is a partial backport of core#25717
https://github.com/bitcoin/bitcoin/pull/25717/commits/84852bb6bb3579e475ce78fe729fd125ddbc715f

Depends on D15213

Test Plan

ninja all check-all

Run the fuzzer

cmake -GNinja .. \
  -DCMAKE_C_COMPILER=clang \
  -DCMAKE_CXX_COMPILER=clang++ \
  -DENABLE_SANITIZERS="fuzzer;address;undefined"
ninja bitcoin-fuzzers
export DIR_FUZZ_IN=~/dev/qa-assets/fuzz_seed_corpus
./test/fuzz/test_runner.py -g ${DIR_FUZZ_IN} bitdeque

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 26355
Build 52280: Build Diff	lint-circular-dependencies · build-without-wallet · build-diff · build-fuzzer · build-debug · build-clang-tidy · build-clang
Build 52279: arc lint + arc unit

Event Timeline

PiRK created this revision.Jan 10 2024, 08:42

Herald added a reviewer: Restricted Project. · View Herald TranscriptJan 10 2024, 08:42

PiRK requested review of this revision.Jan 10 2024, 08:42

teamcity edited the summary of this revision. (Show Details)Jan 10 2024, 08:43

PiRK added a child revision: D15125: Add functions to construct locators without CChain.Jan 10 2024, 08:45

Harbormaster completed remote builds in B26236: Diff 44012.Jan 10 2024, 09:01

Fabien requested changes to this revision.Jan 10 2024, 16:51

Fabien added a subscriber: Fabien.

Fabien added inline comments.

src/test/util_tests.cpp
16 ↗	(On Diff #44012)	So we know it builds, but still there is no test. We should really catch up on the fuzzer, or write some tests for this class

This revision now requires changes to proceed.Jan 10 2024, 16:51

add fuzer

PiRK edited the test plan for this revision. (Show Details)Jan 15 2024, 13:46

Harbormaster completed remote builds in B26355: Diff 44177.Jan 15 2024, 14:13

Fabien accepted this revision.Jan 15 2024, 17:33

This revision is now accepted and ready to land.Jan 15 2024, 17:33

Closed by commit rABC6040be892224: Add bitdeque, an std::deque<bool> analogue that does bit packing. (authored by Pieter Wuille <pieter@wuille.net>, committed by PiRK). · Explain WhyJan 16 2024, 08:11

This revision was automatically updated to reflect the committed changes.

PiRK added a commit: rABC6040be892224: Add bitdeque, an std::deque<bool> analogue that does bit packing..

Revision Contents
Changeset List

Path

Size

src/

test/

fuzz/

1 line

596 lines

1 line

util/

514 lines

Diff 44177

src/test/fuzz/CMakeLists.txt

Loading...

src/test/fuzz/bitdeque.cpp

Loading...

src/test/util_tests.cpp

Loading...

src/util/bitdeque.h

Loading...