Page MenuHomePhabricator
Differential D15197

[electrum] bump minimum required version of trezorlib to 0.13.8
ClosedPublic
Actions

Authored by PiRK on Jan 18 2024, 12:16.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABC833a6a2fed41: [electrum] bump minimum required version of trezorlib to 0.13.8
Summary

This seems to be enough to support the new Trezor Safe 3 devices, according to tests done by Electron Cash and Electrum users.
I did not test the new device myself.

See electrum#8722 and electroncash#2757

Test Plan

Install that version of the trezor library for python and test that trezor wallets still work in the application (tested with a Trezor T).

pip install trezor==0.13.8
./electrum-abc

I also tested the appimage (contrib/build-linux/appimage/build.sh)

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

PiRK created this revision.Jan 18 2024, 12:16
Herald added a reviewer: Restricted Project. · View Herald TranscriptJan 18 2024, 12:16
PiRK requested review of this revision.Jan 18 2024, 12:16
teamcity edited the summary of this revision. (Show Details)Jan 18 2024, 12:16
PiRK edited the summary of this revision. (Show Details)Jan 18 2024, 12:17
PiRK edited the test plan for this revision. (Show Details)
PiRK added inline comments.Jan 18 2024, 12:20
electrum/contrib/deterministic-build/requirements-hw.txt
345 ↗(On Diff #44318)

hashes can be compared to the release files on https://pypi.org/project/trezor/0.13.8/#files

Harbormaster completed remote builds in B26458: Diff 44318.Jan 18 2024, 12:32
Fabien accepted this revision.Jan 18 2024, 12:50
This revision is now accepted and ready to land.Jan 18 2024, 12:50
Closed by commit rABC833a6a2fed41: [electrum] bump minimum required version of trezorlib to 0.13.8 (authored by PiRK). · Explain WhyJan 18 2024, 14:15
This revision was automatically updated to reflect the committed changes.
PiRK added a commit: rABC833a6a2fed41: [electrum] bump minimum required version of trezorlib to 0.13.8.

Revision Contents
Changeset List

PathSize
electrum/
contrib/
deterministic-build/
6 lines
requirements/
2 lines
electrumabc_plugins/
trezor/
2 lines

Diff 44322

View Options

electrum/contrib/deterministic-build/requirements-hw.txt

Loading...
View Options

electrum/contrib/requirements/requirements-hw.txt

Loading...
View Options

electrum/electrumabc_plugins/trezor/trezor.py

Loading...