Update integration tests for Home screen
Snapshot tests are using bad mocks and not actually testing anything. Add some useful tests.
Details
Details
- Reviewers
emack - Group Reviewers
Restricted Project - Commits
- rABCd8982267b961: [Cashtab] Better testing for Home.js screen
npm test
Diff Detail
Diff Detail
- Repository
- rABC Bitcoin ABC
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
| cashtab/src/components/Home/__tests__/Home.test.js | ||
|---|---|---|
| 41 ↗ | (On Diff #44337) | why are you adding new code with a "deprecated" comment ? |
Comment Actions
remove deprecated mock methods
| cashtab/src/components/Home/__tests__/Home.test.js | ||
|---|---|---|
| 41 ↗ | (On Diff #44337) | copypasta from the above source url. Without this routine, was getting a common error arising from not having the window object outside a web browser. Removing the deprecated ones everything still works, so, removed. |
| cashtab/src/components/Home/__tests__/Home.test.js | ||
|---|---|---|
| 41 ↗ | (On Diff #44337) | Removing these lines from SendXec.test.js or SendTokenValidation.test.js causes test to fail. They are likely still being used by antd components so need to be mocked. Leaving them here so that the link describing where it came from is consistent with the text. Getting rid of antd would be a big win for Cashtab but that will take some time. |
| cashtab/src/components/Home/__tests__/Home.test.js | ||
|---|---|---|
| 158 ↗ | (On Diff #44342) | Is there a way to verify that <HiddenBalanceCtn> is rendered (instread of 'balance-header-rendered') when cashtabSettings.balanceVisible is false? i.e. the equivalent of render.current.statevar=false in the renderHook approach. I think that deserves its own test case. |
| cashtab/src/components/Home/__tests__/Home.test.js | ||
|---|---|---|
| 158 ↗ | (On Diff #44342) | Yes -- I am working on a much better way to handle this. See D15205 Will
Home screen should really just be testing integration stuff on home screen. The way it's written now, the balance rendering stuff is part of this. But those tests should really belong to BalanceHeader. |