Use block timestamp for tx timestamp in history if data.timeFirstSeen is unavailable
Patches a bug where a tx with no timeFirstSeen that is unconfirmed would fail to render.
Details
Details
- Reviewers
emack - Group Reviewers
Restricted Project - Commits
- rABC70bf98f53ad4: [Cashtab] If timeFirstSeen is 0, use block timestamp in tx history
npm test
Diff Detail
Diff Detail
- Repository
- rABC Bitcoin ABC
- Branch
- timestamp-coinbase
- Lint
Lint Passed - Unit
No Test Coverage - Build Status
Buildable 26500 Build 52570: Build Diff cashtab-tests Build 52569: arc lint + arc unit
Event Timeline
Comment Actions
Would it be handy for you to share the wallet (via tg) that contained this non-render so I can test against master vs this patch?
Comment Actions
lol the point of these integration tests is that we can catch hypotheticals without laboriously producing them in the wild. I personally haven't seen this, but if it happens will impact prod.
Would require a chronik outage followed by a quick chronik reboot and a user having received a still-unconfirmed tx during the outage. some edge case but should be handled.
More common issue fixed by this diff is staking rewards, which, as coinbase txs, have timeFirstSeen: '0', and should properly have a txTime of the block time.