[Cashtab] If timeFirstSeen is 0, use block timestamp in tx history
ClosedPublic
Actions

Authored by bytesofman on Jan 19 2024, 23:43.

Details

Reviewers

emack

Group Reviewers

Restricted Project

Commits

rABC70bf98f53ad4: [Cashtab] If timeFirstSeen is 0, use block timestamp in tx history

Summary

Use block timestamp for tx timestamp in history if data.timeFirstSeen is unavailable

Patches a bug where a tx with no timeFirstSeen that is unconfirmed would fail to render.

Test Plan

npm test

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

bytesofman created this revision.Jan 19 2024, 23:43

Herald added a reviewer: Restricted Project. · View Herald TranscriptJan 19 2024, 23:43

bytesofman published this revision for review.Jan 19 2024, 23:43

Harbormaster completed remote builds in B26500: Diff 44375.Jan 19 2024, 23:46

Would it be handy for you to share the wallet (via tg) that contained this non-render so I can test against master vs this patch?

In D15215#341976, @emack wrote:

Would it be handy for you to share the wallet (via tg) that contained this non-render so I can test against master vs this patch?

lol the point of these integration tests is that we can catch hypotheticals without laboriously producing them in the wild. I personally haven't seen this, but if it happens will impact prod.

Would require a chronik outage followed by a quick chronik reboot and a user having received a still-unconfirmed tx during the outage. some edge case but should be handled.

More common issue fixed by this diff is staking rewards, which, as coinbase txs, have timeFirstSeen: '0', and should properly have a txTime of the block time.

emack accepted this revision.Jan 20 2024, 22:22

This revision is now accepted and ready to land.Jan 20 2024, 22:22

Closed by commit rABC70bf98f53ad4: [Cashtab] If timeFirstSeen is 0, use block timestamp in tx history (authored by bytesofman). · Explain WhyJan 20 2024, 23:50

This revision was automatically updated to reflect the committed changes.

bytesofman added a commit: rABC70bf98f53ad4: [Cashtab] If timeFirstSeen is 0, use block timestamp in tx history.