Page MenuHomePhabricator
Differential D15232

[electrum] remove the test duplication for the cashaddr prefix
AbandonedPublic
Actions

Authored by PiRK on Jan 22 2024, 15:19.

Details

Reviewers
bytesofman
Group Reviewers
Restricted Project
Summary

Nowadays we don't expect much bitcoincash: prefixing any longer. The code still supports it, so keep one test.

Depends on D15231

Test Plan

python test_runner.py

Diff Detail

Event Timeline

PiRK created this revision.Jan 22 2024, 15:19
Herald added a reviewer: Restricted Project. · View Herald TranscriptJan 22 2024, 15:19
PiRK requested review of this revision.Jan 22 2024, 15:19
Harbormaster completed remote builds in B26545: Diff 44439.Jan 22 2024, 15:43
PiRK updated this revision to Diff 44446.Jan 22 2024, 16:40

rebase

Harbormaster completed remote builds in B26552: Diff 44446.Jan 22 2024, 16:42
bytesofman requested changes to this revision.Jan 22 2024, 18:10
bytesofman added a subscriber: bytesofman.
bytesofman added inline comments.
electrum/electrumabc/tests/test_bip21.py
15

should we keep supporting this?

the point of ecash: is that it prevents someone from accidentally sending ecash when they think they are sending bch. Probably time to simply deprecate this.

This revision now requires changes to proceed.Jan 22 2024, 18:10
PiRK abandoned this revision.Jan 23 2024, 10:14

replaced by D15245

Revision Contents
Changeset List

PathSize
electrum/
electrumabc/
tests/
55 lines

Diff 44446

View Options

electrum/electrumabc/tests/test_bip21.py

Loading...