Page MenuHomePhabricator
Differential D15231

[electrum] escape special chars in URI for op_return message
ClosedPublic
Actions

Authored by PiRK on Jan 22 2024, 15:10.

Details

Reviewers
bytesofman
Group Reviewers
Restricted Project
Commits
rABCa31855862452: [electrum] escape special chars in URI for op_return message
Summary

As per title

Depends on D15236

Test Plan

python test_runner.py

In the "receive" tab, enter weird stuff in the OP_RETURN field with the "Raw hex script" option unchecked. Click the "Copy URI", paste it in a notebook and check that special chars are escaped and URI-safe.

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

PiRK created this revision.Jan 22 2024, 15:10
Herald added a reviewer: Restricted Project. · View Herald TranscriptJan 22 2024, 15:10
PiRK requested review of this revision.Jan 22 2024, 15:10
PiRK added a child revision: D15232: [electrum] remove the test duplication for the cashaddr prefix.Jan 22 2024, 15:19
Harbormaster completed remote builds in B26544: Diff 44438.Jan 22 2024, 15:42
PiRK updated this revision to Diff 44445.Jan 22 2024, 16:39
PiRK edited the summary of this revision. (Show Details)
PiRK added a parent revision: D15236: [electrum] add tests for BIP21 parsing and creation.

rebase

Harbormaster completed remote builds in B26551: Diff 44445.Jan 22 2024, 16:41
bytesofman added a subscriber: bytesofman.Jan 22 2024, 18:07

update phab depends on chain to get rid of the abandoned diff

image.png (444×742 px, 68 KB)

bytesofman requested changes to this revision.Jan 22 2024, 18:09

think the phab dependency thing is preventing arc patch here

image.png (271×637 px, 29 KB)

This revision now requires changes to proceed.Jan 22 2024, 18:09
PiRK requested review of this revision.Jan 22 2024, 20:56
PiRK removed a parent revision: D15229: [electrum] clean and add tests for BIP21.

I removed the abandoned parent revision as a dependency.

PiRK edited the test plan for this revision. (Show Details)Jan 22 2024, 20:57
bytesofman accepted this revision.Jan 22 2024, 21:18
This revision is now accepted and ready to land.Jan 22 2024, 21:18
Closed by commit rABCa31855862452: [electrum] escape special chars in URI for op_return message (authored by PiRK). · Explain WhyJan 23 2024, 07:46
This revision was automatically updated to reflect the committed changes.
PiRK added a commit: rABCa31855862452: [electrum] escape special chars in URI for op_return message.

Revision Contents
Changeset List

PathSize
electrum/
electrumabc/
tests/
4 lines
2 lines

Diff 44473

View Options

electrum/electrumabc/tests/test_bip21.py

Loading...
View Options

electrum/electrumabc/web.py

Loading...