Page MenuHomePhabricator
Differential D15245

[electrum] drop support for "bitcoincash:..." addresses
ClosedPublic
Actions

Authored by PiRK on Jan 23 2024, 09:57.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABC6bc398c835f7: [electrum] drop support for "bitcoincash:..." addresses
Summary

After this diff, bch cash addresses are no longer supported in the "Pay to" field, in BIP21 URIs or any method of entering an address that uses Address.from_string without setting support_arbitrary_prefix=True.

The address converter in the GUI still support any prefix. This diff also makes the command line / RPC addressconvert command support arbitrary prefixes.
But now we no longer support bch addresses without an explicit prefix.

This diff also incidentally fixes support for "ectest:..." URIs when running in testnet mode. Previously web.parseable_schemes did not correctly account for the net parameter, and always returned ("ecash", "bitcoincash")

This is a follow-up to https://github.com/Bitcoin-ABC/ElectrumABC/pull/250 (dropping of display of BCH addresses in the UI).

Test Plan
python test_runner.py
pytest electrumabc.tests.regtest

Try the address converter tool in the prefix with various address formats. It should still support everything it did before, except for prefixless "bitcoincash:..." cash addresses.

Diff Detail

Event Timeline

PiRK created this revision.Jan 23 2024, 09:57
Herald added a reviewer: Restricted Project. · View Herald TranscriptJan 23 2024, 09:57
PiRK requested review of this revision.Jan 23 2024, 09:57
Harbormaster completed remote builds in B26572: Diff 44475.Jan 23 2024, 10:02
PiRK edited the summary of this revision. (Show Details)Jan 23 2024, 10:03

There will be a release note for this. I usually add release notes when I bump the version just before a release.

PiRK updated this revision to Diff 44476.Jan 23 2024, 10:10
PiRK edited the summary of this revision. (Show Details)

further simplification in Address.from_cashaddr_string : use the net to get the correct prefix.

Harbormaster completed remote builds in B26573: Diff 44476.Jan 23 2024, 10:12
PiRK mentioned this in D15232: [electrum] remove the test duplication for the cashaddr prefix.Jan 23 2024, 10:14
Fabien accepted this revision.Jan 23 2024, 15:32
This revision is now accepted and ready to land.Jan 23 2024, 15:32
PiRK added a child revision: D15250: [electrum] support parsing multi-output URIs.Jan 23 2024, 15:54
Closed by commit rABC6bc398c835f7: [electrum] drop support for "bitcoincash:..." addresses (authored by PiRK). · Explain WhyJan 23 2024, 16:20
This revision was automatically updated to reflect the committed changes.
PiRK added a commit: rABC6bc398c835f7: [electrum] drop support for "bitcoincash:..." addresses.
PiRK removed a child revision: D15250: [electrum] support parsing multi-output URIs.Jan 23 2024, 21:00
PiRK added a child revision: D15250: [electrum] support parsing multi-output URIs.Jan 23 2024, 21:22
PiRK removed a child revision: D15250: [electrum] support parsing multi-output URIs.Feb 5 2024, 17:59

Revision Contents
Changeset List

PathSize
electrum/
electrumabc/
43 lines
2 lines
14 lines
tests/
regtest/
16 lines
22 lines
91 lines
12 lines
3 lines
electrumabc_plugins/
fusion/
tests/
6 lines

Diff 44475

View Options

electrum/electrumabc/address.py

Loading...
View Options

electrum/electrumabc/commands.py

Loading...
View Options

electrum/electrumabc/constants.py

Loading...
View Options

electrum/electrumabc/tests/regtest/test_rpc_misc.py

Loading...
View Options

electrum/electrumabc/tests/test_address.py

Loading...
View Options

electrum/electrumabc/tests/test_bip21.py

Loading...
View Options

electrum/electrumabc/tests/test_wallet.py

Loading...
View Options

electrum/electrumabc/web.py

Loading...
View Options

electrum/electrumabc_plugins/fusion/tests/test_util.py

Loading...