Page MenuHomePhabricator

[Cashtab] Remove babel settings from package.json
ClosedPublic

Authored by bytesofman on Jan 23 2024, 23:53.

Details

Reviewers
PiRK
Group Reviewers
Restricted Project
Commits
rABC01750b830b97: [Cashtab] Remove babel settings from package.json
Summary

Depends on D15257

Move babel settings to own file. It's otherwise not obvious they would be in package.json.

Test Plan

Re-insert key and npm run build
Delete key and npm run build

The hashes are unchanged (can see in extension of build/static/js/*.js files)

npm test

Diff Detail

Repository
rABC Bitcoin ABC
Branch
pkgjson-cleanup
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 26601
Build 52772: Build Diffcashtab-tests
Build 52771: arc lint + arc unit

Event Timeline

Tail of the build log:

    SyntaxError: Cannot use import statement outside a module

      at Module._compile (node_modules/pirates/lib/index.js:117:24)
      at Object.newLoader [as .js] (node_modules/pirates/lib/index.js:121:7)

FAIL src/opreturn/__tests__/index.test.js
  ● Test suite failed to run

    /work/cashtab/config/jest/uint8array-environment.js:1
    import JSDOMEnvironment from 'jest-environment-jsdom';
    ^^^^^^

    SyntaxError: Cannot use import statement outside a module

      at Module._compile (node_modules/pirates/lib/index.js:117:24)
      at Object.newLoader [as .js] (node_modules/pirates/lib/index.js:121:7)

FAIL src/utils/__tests__/formatting.test.js
  ● Test suite failed to run

    /work/cashtab/config/jest/uint8array-environment.js:1
    import JSDOMEnvironment from 'jest-environment-jsdom';
    ^^^^^^

    SyntaxError: Cannot use import statement outside a module

      at Module._compile (node_modules/pirates/lib/index.js:117:24)
      at Object.newLoader [as .js] (node_modules/pirates/lib/index.js:121:7)

FAIL src/utils/__tests__/aliasUtils.test.js
  ● Test suite failed to run

    /work/cashtab/config/jest/uint8array-environment.js:1
    import JSDOMEnvironment from 'jest-environment-jsdom';
    ^^^^^^

    SyntaxError: Cannot use import statement outside a module

      at Module._compile (node_modules/pirates/lib/index.js:117:24)
      at Object.newLoader [as .js] (node_modules/pirates/lib/index.js:121:7)

FAIL src/components/Home/__tests__/Home.test.js
  ● Test suite failed to run

    /work/cashtab/config/jest/uint8array-environment.js:1
    import JSDOMEnvironment from 'jest-environment-jsdom';
    ^^^^^^

    SyntaxError: Cannot use import statement outside a module

      at Module._compile (node_modules/pirates/lib/index.js:117:24)
      at Object.newLoader [as .js] (node_modules/pirates/lib/index.js:121:7)


Test Suites: 21 failed, 21 total
Tests:       0 total
Snapshots:   0 total
Time:        2.634 s
Ran all test suites.
Build cashtab-tests failed with exit code 1

move babel setting to its own file

bytesofman edited the test plan for this revision. (Show Details)
This revision is now accepted and ready to land.Jan 24 2024, 08:42