Details

Reviewers

Group Reviewers

Restricted Project

Commits

rABCd23ecd73498a: [Cashtab] Standardize wallet refresh interval

Summary

This diff standardizes the wallet refresh interval to 60 seconds.
Note: this is the fallback interval, as websocket events processed by processChronikWsMsg will still trigger instant refreshes.

The reasoning for moving away from basing fallback refresh intervals on websocket availability is because if there is no websocket then there is no chronik server either, so no need to distinguish between the two.

Test Plan

npm test

grep -r websocketConnectedRefreshInterval src/ with no output
npm start
open dev console and observe the Websocket connected, adjusting wallet refresh interval to 60s message upon initial load
send XEC to this wallet and ensure instant refresh

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

emack created this revision.Jan 25 2024, 13:55

Herald added a reviewer: Restricted Project. · View Herald TranscriptJan 25 2024, 13:55

emack requested review of this revision.Jan 25 2024, 13:55

Harbormaster completed remote builds in B26651: Diff 44583.Jan 25 2024, 13:58

bytesofman requested changes to this revision.Jan 25 2024, 14:45

bytesofman added inline comments.

cashtab/src/hooks/useWallet.js
1539–1542 ↗	(On Diff #44583)	Remove. We no longer want to be setting to the disconnected interval. Here, we are just setting from `websocketRefreshInterval` to `websocketRefreshInterval`

This revision now requires changes to proceed.Jan 25 2024, 14:45

Removed interval setting in activateWallet per feedback

Harbormaster completed remote builds in B26662: Diff 44602.Jan 26 2024, 02:24

simple diff so tempting to combine them but we are doing 2 things here

get rid of the websocketDisconnectedRefreshInterval
change existing interval

should be two diffs, in the above order

also version bump

This revision now requires changes to proceed.Jan 26 2024, 12:12

emack mentioned this in D15296: [Cashtab] Remove websocketDisconnectedRefreshInterval.Jan 26 2024, 13:56

emack mentioned this in rABC2fa51d222382: [Cashtab] Remove websocketDisconnectedRefreshInterval.Jan 26 2024, 14:25

emack edited the test plan for this revision. (Show Details)Jan 26 2024, 14:30

Rebased to D15296 and version bump

emack edited the summary of this revision. (Show Details)Jan 26 2024, 14:36

not sure about this in the test plan?

open dev console and observe the Websocket connected, adjusting wallet refresh interval to 60s messages and ensure they are appearing at 1 minute intervals

we should only see this once, on loading. are you seeing this every minute?

please update the test plan to confirm the websocket is not re-initializing every 60s. If this is happening, need a diff to fix.

This revision now requires changes to proceed.Jan 26 2024, 14:48

Harbormaster completed remote builds in B26682: Diff 44628.Jan 26 2024, 14:55

In D15281#343784, @bytesofman wrote:

please update the test plan to confirm the websocket is not re-initializing every 60s. If this is happening, need a diff to fix.

It is indeed not re-initializing every 60s, only upon initial load. Test plan updated.

version bump

Harbormaster completed remote builds in B26695: Diff 44653.Jan 27 2024, 02:02

rebase + version bump before landing

This revision is now accepted and ready to land.Jan 27 2024, 15:26

rebase + version bump

This revision was landed with ongoing or failed builds.Jan 28 2024, 08:52

Closed by commit rABCd23ecd73498a: [Cashtab] Standardize wallet refresh interval (authored by emack). · Explain Why

This revision was automatically updated to reflect the committed changes.

emack added a commit: rABCd23ecd73498a: [Cashtab] Standardize wallet refresh interval.

Harbormaster completed remote builds in B26698: Diff 44657.Jan 28 2024, 08:54

emack mentioned this in D15403: [Cashtab] Increase txHistoryCount to 20.Feb 7 2024, 02:45