Page MenuHomePhabricator

[net processing] Annotate nUnconnectingHeaders as guarded by g_msgproc_mutex and move to Peer
ClosedPublic

Authored by PiRK on Jan 26 2024, 10:16.

Details

Summary

nUnconnectingHeaders, m_headers_sync_timeout, fPreferHeaders and m_recently_announced_headers are currently all CNodeState members even though they are only ever accessed from the message processing thread (therefore sufficiently guarded exclusively by g_msgproc_mutex). CNodeState exists purely to hold validation-specific state guarded by cs_main that is accessed by multiple threads.

This is a partial backport of core#26140
https://github.com/bitcoin/bitcoin/pull/26140/commits/5f80d8d1eec14253407ceed1a813619d3e5a0fe4
https://github.com/bitcoin/bitcoin/pull/26140/commits/d8c0d1c345546c6066274edbf3bf4fb5d6f75419
Depends on D15288

Test Plan

With Debug:

ninja all check-all