ArgsMan: Add Get*Arg functions returning optional
ClosedPublic
Actions

Authored by PiRK on Jan 26 2024, 16:00.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rABCaabc65b82c1b: ArgsMan: Add Get*Arg functions returning optional

Summary

This allows the caller to not provide a default at all and just check
inside the optional to see if the arg was set or not.

This is a partial backport of core#25290
https://github.com/bitcoin/bitcoin/pull/25290/commits/fc02f77ca604f0221171bfde3059b34f5d0fb1cd

Test Plan

ninja all check-all

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 26711
Build 52990: Build Diff	build-diff · build-clang · build-clang-tidy · lint-circular-dependencies · build-debug · build-without-wallet
Build 52989: arc lint + arc unit

Event Timeline

PiRK created this revision.Jan 26 2024, 16:00

Herald added a reviewer: Restricted Project. · View Herald TranscriptJan 26 2024, 16:00

PiRK requested review of this revision.Jan 26 2024, 16:00

teamcity edited the summary of this revision. (Show Details)Jan 26 2024, 16:00

PiRK added a child revision: D15298: scripted-diff: Rename DEFAULT_MAX_MEMPOOL_SIZE to indicate SI unit.Jan 26 2024, 16:02

Harbormaster completed remote builds in B26686: Diff 44635.Jan 26 2024, 16:37

Macro lackoftest:

This revision now requires changes to proceed.Jan 26 2024, 19:45

The existing functions now call the new functions, so everything should still be pretty much covered by the existing getarg_tests

rebase

In D15297#343995, @PiRK wrote:

The existing functions now call the new functions, so everything should still be pretty much covered by the existing getarg_tests

Good point

Fabien accepted this revision.Jan 29 2024, 14:32

This revision is now accepted and ready to land.Jan 29 2024, 14:32

Harbormaster completed remote builds in B26711: Diff 44679.Jan 29 2024, 14:35

Closed by commit rABCaabc65b82c1b: ArgsMan: Add Get*Arg functions returning optional (authored by Carl Dong <contact@carldong.me>, committed by PiRK). · Explain WhyJan 30 2024, 09:35

This revision was automatically updated to reflect the committed changes.

PiRK added a commit: rABCaabc65b82c1b: ArgsMan: Add Get*Arg functions returning optional.