Paths

Table of Contentst

Differential D15309

Move MakeNoLogFileContext to common libtest_util, and use it in bench
ClosedPublic
Actions

Authored by PiRK on Jan 29 2024, 09:16.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rABCd8538ef31fb4: Move MakeNoLogFileContext to common libtest_util, and use it in bench

Summary

Can be reviewed with --color-moved=dimmed-zebra

This is a backport of core#21003
Depends on D15308

Test Plan

ninja check bitcoin-fuzzers bench-bitcoin

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

PiRK created this revision.Jan 29 2024, 09:16

Herald added a reviewer: Restricted Project. · View Herald TranscriptJan 29 2024, 09:16

PiRK requested review of this revision.Jan 29 2024, 09:16

teamcity edited the summary of this revision. (Show Details)Jan 29 2024, 09:17

PiRK added a child revision: D15310: Add test util to populate mempool with random transactions.Jan 29 2024, 09:41

Fabien accepted this revision.Jan 29 2024, 09:49

Fabien added a subscriber: Fabien.

Fabien added inline comments.

src/bench/rpc_blockchain.cpp
19 ↗	(On Diff #44670)	auto ?

This revision is now accepted and ready to land.Jan 29 2024, 09:49

PiRK added inline comments.Jan 29 2024, 09:56

src/bench/rpc_blockchain.cpp
19 ↗	(On Diff #44670)	So this seems to be illegal for complicated reasons (https://stackoverflow.com/a/11303175/4494781)

Harbormaster completed remote builds in B26708: Diff 44670.Jan 29 2024, 10:18

Closed by commit rABCd8538ef31fb4: Move MakeNoLogFileContext to common libtest_util, and use it in bench (authored by MarcoFalke <falke.marco@gmail.com>, committed by PiRK). · Explain WhyJan 29 2024, 10:50

This revision was automatically updated to reflect the committed changes.

PiRK added a commit: rABCd8538ef31fb4: Move MakeNoLogFileContext to common libtest_util, and use it in bench.

Revision Contents
Changeset List

Path

Size

src/

bench/

15 lines

12 lines

11 lines

4 lines

11 lines

17 lines

test/

fuzz/

1 line

1 line

1 line

15 lines

util/

setup_common.h

19 lines

Diff 44676

View Options

src/bench/block_assemble.cpp

View Options

src/bench/duplicate_inputs.cpp

View Options

src/bench/mempool_eviction.cpp

View Options

src/bench/mempool_stress.cpp

View Options

src/bench/rpc_blockchain.cpp

View Options

src/bench/wallet_balance.cpp

View Options

src/test/fuzz/banman.cpp

View Options

src/test/fuzz/coins_view.cpp

View Options

src/test/fuzz/connman.cpp

View Options

src/test/fuzz/util.h

View Options

src/test/util/setup_common.h

Move MakeNoLogFileContext to common libtest_util, and use it in benchClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 44676

src/bench/block_assemble.cpp

src/bench/duplicate_inputs.cpp

src/bench/mempool_eviction.cpp

src/bench/mempool_stress.cpp

src/bench/rpc_blockchain.cpp

src/bench/wallet_balance.cpp

src/test/fuzz/banman.cpp

src/test/fuzz/coins_view.cpp

src/test/fuzz/connman.cpp

src/test/fuzz/util.h

src/test/util/setup_common.h

Move MakeNoLogFileContext to common libtest_util, and use it in bench
ClosedPublic
Actions

Revision Contents
Changeset List