Page MenuHomePhabricator

Make comments in abandonconflict legible.

Authored by schancel on Jul 2 2018, 23:43.


Diff Detail

rABC Bitcoin ABC
Lint Not Applicable
Tests Not Applicable

Event Timeline

jasonbcox requested changes to this revision.Jul 2 2018, 23:57
jasonbcox added a subscriber: jasonbcox.
jasonbcox added inline comments.
95 ↗(On Diff #4188)

Transactino -> Transaction

98 ↗(On Diff #4188)

Please add a note either here or far before this comment that indicates that the wallet and mempool do not have to be in sync. This is a very strange concept in my opinion and deserves its own documentation.

123 ↗(On Diff #4188)

Can you clarify the first sentence here? Does this imply that an abandoned tx is the exact same thing as a tx that is not in the mempool? If there are differences between these, please make that explicit. At the moment, it sounds like an abandon tx may be a subclass of not-in-mempool transactions?

This revision now requires changes to proceed.Jul 2 2018, 23:57
This revision is now accepted and ready to land.Jul 3 2018, 02:44
This revision was automatically updated to reflect the committed changes.