Page MenuHomePhabricator

Make comments in abandonconflict legible.
ClosedPublic

Authored by schancel on Jul 2 2018, 23:43.

Details

Diff Detail

Repository
rABC Bitcoin ABC
Branch
nits
Lint
Lint OK
Unit
No Unit Test Coverage
Build Status
Buildable 2789
Build 3688: Bitcoin ABC Teamcity Staging
Build 3687: arc lint + arc unit

Event Timeline

schancel created this revision.Jul 2 2018, 23:43
Herald added a reviewer: Restricted Project. · View Herald TranscriptJul 2 2018, 23:43
schancel updated this revision to Diff 4188.Jul 2 2018, 23:44

Fix a comment

jasonbcox requested changes to this revision.Jul 2 2018, 23:57
jasonbcox added a subscriber: jasonbcox.
jasonbcox added inline comments.
test/functional/abandonconflict.py
95

Transactino -> Transaction

98

Please add a note either here or far before this comment that indicates that the wallet and mempool do not have to be in sync. This is a very strange concept in my opinion and deserves its own documentation.

123

Can you clarify the first sentence here? Does this imply that an abandoned tx is the exact same thing as a tx that is not in the mempool? If there are differences between these, please make that explicit. At the moment, it sounds like an abandon tx may be a subclass of not-in-mempool transactions?

This revision now requires changes to proceed.Jul 2 2018, 23:57
schancel updated this revision to Diff 4189.Jul 3 2018, 01:30

Reword a few things

jasonbcox accepted this revision.Jul 3 2018, 02:44
This revision is now accepted and ready to land.Jul 3 2018, 02:44
This revision was automatically updated to reflect the committed changes.