Upgrade qrcode.react dependency. Implement with new syntax.
This gives us more options for improving the qr code, and also supports upgrading to react 18.
Details
Details
- Reviewers
emack - Group Reviewers
Restricted Project - Commits
- rABCca40af281a12: [Cashtab] Upgrade qrcode.react
npm test
npm start and confirm you can still scan the qr code at screen widths of 320px through 800px
Diff Detail
Diff Detail
- Repository
- rABC Bitcoin ABC
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
Comment Actions
reminder to npm i prior to rebase/land to sync up package-lock.json versioning
also update test plan to validate QR code being rendered and scanned successfully (tested all ok from my side)
Comment Actions
let's not do this. we don't want package-lock.json to change unless some dependencies have changed. So, the version in package-lock.json is just the version where dependencies last changed.
It's too much hassle to change this manually all the time, and also it implies we are changing dependencies.
also update test plan to validate QR code being rendered and scanned successfully (tested all ok from my side)
yup good point. mb version 3 will let us make the icon bigger and still have scanning ok as well, but that would be another diff