Differential D15353
[Cashtab] Upgrade antd Authored by bytesofman on Jan 31 2024, 23:27.
Details
Upgrade antd and related dependency antd/icons For the most part, this seems to improve Cashtab look and feel. The h3 and h4 components appear off. Added light css fixes where this upgrade broke existing css. I was not able to color match the char count on the text input fields of the SignVerifyMsg screen. imo this is not a big deal, still looks about the same. Background: need to do this in order to upgrade to React 18, which we need to do in order to test localforage in the useWallet hook npm test
Diff Detail
Event Timeline
Comment Actions When testing on mobile, both iOS and android devices are showing the create token button stretching off to the right of the screen. It's not the case with master. (via antdtest.netlify.app)  Also re: notifs, I know you said it doesn't need to be 100% as before but the icon being squashed against the message here is a bit too noticeable. before:  after:  Overall the rounding of dropdowns, buttons, notifs...etc looks great! Comment Actions
good catches create token issue patched, kinda lazily bc the button imo needs to be changed anyway  We really should have a PrimaryButton and SecondaryButton, not from antd, both capable of accepting 'disabled' as a prop which changes their appearance (different bg color, different font color). As for the notifications, I just made the size smaller and a square. imo good enough for the upgrade, since we are already looking at improving these in general separately.  | ||||||||||||||||||||||||||||||||||||||||||||