Page MenuHomePhabricator
Differential D15357

[electrum] run black linter on scripts
ClosedPublic
Actions

Authored by PiRK on Feb 1 2024, 10:51.

Details

Reviewers
bytesofman
Group Reviewers
Restricted Project
Commits
rABCb1963b32cf36: [electrum] run black linter on scripts
Summary

Some python scripts don't have a .py extension. This is a manual run prior to renaming the files so that they will be linted in the future.
The main entry point for the application will not get an extension, so add it to includes in .arclint
Depends on D15362

Test Plan

arc lint -- electrum/electrum-abc

Diff Detail

Repository
rABC Bitcoin ABC
Branch
get_merkle_root_verbosity
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 26829
Build 53226: Build Diffelectrum-tests
Build 53225: arc lint + arc unit

Event Timeline

PiRK created this revision.Feb 1 2024, 10:51
Herald added a reviewer: Restricted Project. · View Herald TranscriptFeb 1 2024, 10:51
PiRK requested review of this revision.Feb 1 2024, 10:51
Harbormaster completed remote builds in B26828: Diff 44840.Feb 1 2024, 10:53
PiRK updated this revision to Diff 44841.Feb 1 2024, 10:53

the extra blank line after the imports is not mandatory and not corrected by black (debugging leftover)

Harbormaster completed remote builds in B26829: Diff 44841.Feb 1 2024, 10:55
PiRK added a child revision: D15358: [electrum] run isort on python scripts with no extension.Feb 1 2024, 10:56
PiRK updated this revision to Diff 44856.Feb 1 2024, 14:04
PiRK retitled this revision from [electrum] run the black linter on scripts to [electrum] run black linter on scripts.
PiRK edited the summary of this revision. (Show Details)
PiRK edited the test plan for this revision. (Show Details)
PiRK added a parent revision: D15362: [electrum] remove bip70 script.

don't add the scripts to .arclint, just run black manually so we can rename them to .py later

Harbormaster completed remote builds in B26842: Diff 44856.Feb 1 2024, 14:06
bytesofman accepted this revision.Feb 1 2024, 17:29
This revision is now accepted and ready to land.Feb 1 2024, 17:29
Closed by commit rABCb1963b32cf36: [electrum] run black linter on scripts (authored by PiRK). · Explain WhyFeb 2 2024, 07:47
This revision was automatically updated to reflect the committed changes.
PiRK added a commit: rABCb1963b32cf36: [electrum] run black linter on scripts.

Revision Contents
Changeset List

PathSize
6 lines
electrum/
scripts/
4 lines
7 lines

Diff 44841

View Options

.arclint

Loading...
View Options

electrum/scripts/bip70

Loading...
View Options

electrum/scripts/get_merkle_root

Loading...