This diff deprecates sendTokenNotification, burnTokenNotification, createTokenNotification and tokenIconSubmitSuccess, replaced with calls on the antd component directly.
Details
Details
- Reviewers
bytesofman - Group Reviewers
Restricted Project - Commits
- rABCc745741f56cc: [Cashtab] Update Token components with direct calls to antd notifications
- grep -r sendTokenNotification src/ with no output
- grep -r burnTokenNotification src/ with no output
- grep -r createTokenNotification src/ with no output
- grep -r tokenIconSubmitSuccess src/ with no output
- npm test
Diff Detail
Diff Detail
- Repository
- rABC Bitcoin ABC
- Branch
- sendTokenNotifs
- Lint
Lint Passed - Unit
No Test Coverage - Build Status
Buildable 26877 Build 53321: Build Diff cashtab-tests Build 53320: arc lint + arc unit
Event Timeline
Comment Actions
- needs version bump
- Test plan is too complicated. The integration tests added in this diff are thorough and quite good. can eliminate the create a token (no UI change to success and icon submission notifs) and
send a token (no UI change) steps.
if you find the test plan is too complicated -- esp now that we have much better testing libraries and practices in Cashtab -- it is usually a sign that the diff needs another test. goal is for every testplan to just be npm test, so that a reviewer can learn a lot from a successful CI build.