Page MenuHomePhabricator
Differential D15394

[Chronik] Move `BUILD_BITCOIN_CHRONIK_PLUGINS` so we can access it from functional tests
ClosedPublic
Actions

Authored by tobias_ruck on Feb 6 2024, 01:52.

Details

Reviewers
Fabien
PiRK
Group Reviewers
Restricted Project
Commits
rABCe93b8fead2ce: [Chronik] Move `BUILD_BITCOIN_CHRONIK_PLUGINS` so we can access it from…
Summary

By moving the compilation flag to /CMakeLists.txt, we can use it in config.ini.cmake.in and use ENABLE_CHRONIK_PLUGINS in functional tests.

chronik_plugins_setup.py tests just that.

Test Plan
cmake .. -GNinja -DBUILD_BITCOIN_CHRONIK=1 -DBUILD_BITCOIN_CHRONIK_PLUGINS=1
ninja && ./test/functional/test_runner.py chronik_plugins_setup

The test is correctly skipped without -DBUILD_BITCOIN_CHRONIK_PLUGINS=1

Diff Detail

Event Timeline

tobias_ruck created this revision.Feb 6 2024, 01:52
Herald added a reviewer: Restricted Project. · View Herald TranscriptFeb 6 2024, 01:52
tobias_ruck requested review of this revision.Feb 6 2024, 01:52
tobias_ruck mentioned this in D15184: [Chronik] Plugins: Index outputs and return from protobuf.Feb 6 2024, 02:02
Harbormaster completed remote builds in B26946: Diff 44989.Feb 6 2024, 02:13
PiRK requested changes to this revision.Feb 6 2024, 08:11
PiRK edited the test plan for this revision. (Show Details)
PiRK added a subscriber: PiRK.

Lint nits.

test/functional/test_framework/test_framework.py
540–541

Can you run pip install black --upgrade and run arc lint again? See D15374

If you rebase on the current master you should see an error when running arc lint with black < 24

This revision now requires changes to proceed.Feb 6 2024, 08:12
tobias_ruck updated this revision to Diff 44999.Feb 6 2024, 08:59
tobias_ruck edited the test plan for this revision. (Show Details)

fix wrong lint

Harbormaster completed remote builds in B26953: Diff 44999.Feb 6 2024, 09:30
tobias_ruck added a child revision: D15395: [Chronik] Move `chronik-plugin` to `chronik-plugin-impl`, add `chronik-plugin` multiplex crate.Feb 6 2024, 09:48
PiRK accepted this revision.Feb 6 2024, 10:29
This revision is now accepted and ready to land.Feb 6 2024, 10:29
Closed by commit rABCe93b8fead2ce: [Chronik] Move `BUILD_BITCOIN_CHRONIK_PLUGINS` so we can access it from… (authored by tobias_ruck). · Explain WhyFeb 6 2024, 11:39
This revision was automatically updated to reflect the committed changes.
tobias_ruck added a commit: rABCe93b8fead2ce: [Chronik] Move `BUILD_BITCOIN_CHRONIK_PLUGINS` so we can access it from….

Revision Contents
Changeset List

PathSize
1 line
chronik/
2 lines
src/
config/
2 lines
test/
1 line
functional/
28 lines
test_framework/
13 lines

Diff 44989

View Options

CMakeLists.txt

Loading...
View Options

chronik/CMakeLists.txt

Loading...
View Options

src/config/CMakeLists.txt

Loading...
View Options

test/config.ini.cmake.in

Loading...
View Options

test/functional/chronik_plugins_setup.py

Loading...
View Options

test/functional/test_framework/test_framework.py

Loading...