Page MenuHomePhabricator
Differential D15398

[electrum] make get_merkle_root.py work on computers were Electrum ABC was never used
ClosedPublic
Actions

Authored by PiRK on Feb 6 2024, 13:04.

Details

Reviewers
bytesofman
Group Reviewers
Restricted Project
Commits
rABC28732c3a64df: [electrum] make get_merkle_root.py work on computers were Electrum ABC was…
Summary

When Electrum ABC is started for the first time, it creates its user data directory containing a certs directory where SSL certificates are stored. If this directory does not exist, it will fail to connect to servers that use self-signed certificates.

This diff makes the scripts work even if Electrum ABC was never used on a machine. This should fix the CI failure for the new "Update Electrum ABC checkpoints" CI task.

Depends on D15397

Test Plan
mv ~/.electrum-abc/certs/  ~/.electrum-abc/certs-bck
python scripts/get_merkle_root.py -vv
ls  ~/.electrum-abc/certs/

This fails before this diff, and now it works.

Diff Detail

Repository
rABC Bitcoin ABC
Branch
merkle_root_user_dir
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 26960
Build 53486: Build Diffelectrum-tests
Build 53485: arc lint + arc unit

Event Timeline

PiRK created this revision.Feb 6 2024, 13:04
Herald added a reviewer: Restricted Project. · View Herald TranscriptFeb 6 2024, 13:04
PiRK requested review of this revision.Feb 6 2024, 13:04
Harbormaster completed remote builds in B26960: Diff 45007.Feb 6 2024, 13:06
PiRK added inline comments.Feb 6 2024, 13:07
electrum/scripts/util.py
22

make_dir creates the directory if is does not already exist. It is a no-op if it already exists.

bytesofman requested changes to this revision.Feb 6 2024, 13:49
bytesofman added a subscriber: bytesofman.

Depends on D15937

Seems like this is a typo? Prob D15397

This revision now requires changes to proceed.Feb 6 2024, 13:49
bytesofman accepted this revision.Feb 6 2024, 13:49
bytesofman edited the summary of this revision. (Show Details)
bytesofman added a parent revision: D15397: [electrum] use existing util.get_interfaces function for get_merkle_root.
This revision is now accepted and ready to land.Feb 6 2024, 13:50
Closed by commit rABC28732c3a64df: [electrum] make get_merkle_root.py work on computers were Electrum ABC was… (authored by PiRK). · Explain WhyFeb 6 2024, 16:21
This revision was automatically updated to reflect the committed changes.
PiRK added a commit: rABC28732c3a64df: [electrum] make get_merkle_root.py work on computers were Electrum ABC was….

Revision Contents
Changeset List

PathSize
electrum/
scripts/
8 lines

Diff 45007

View Options

electrum/scripts/util.py

Loading...