Page MenuHomePhabricator
Differential D15937

[token-server] Add method to get token inputs and outputs for a token reward tx
ClosedPublic
Actions

Authored by bytesofman on Wed, Apr 10, 17:17.

Details

Reviewers
emack
Group Reviewers
Restricted Project
Commits
rABC8afdf5fc8667: [token-server] Add method to get token inputs and outputs for a token reward tx
Summary

Add tested methods for constructing a token rewards tx

Test Plan

npm test

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

bytesofman created this revision.Wed, Apr 10, 17:17
Herald added a reviewer: Restricted Project. · View Herald TranscriptWed, Apr 10, 17:17
Harbormaster completed remote builds in B28450: Diff 46999.Wed, Apr 10, 17:17
bytesofman updated this revision to Diff 47000.Wed, Apr 10, 17:57

Combine functions, initialize test vector types

Harbormaster completed remote builds in B28451: Diff 47000.Wed, Apr 10, 17:57
bytesofman updated this revision to Diff 47001.Wed, Apr 10, 17:59

undo ecash-lib delete

Harbormaster completed remote builds in B28452: Diff 47001.Wed, Apr 10, 17:59
bytesofman updated this revision to Diff 47002.Wed, Apr 10, 18:27

add tests

Harbormaster completed remote builds in B28453: Diff 47002.Wed, Apr 10, 18:27
bytesofman published this revision for review.Wed, Apr 10, 18:38

publishing despite CI failure as CI issue appears unrelated.

can still be tested with

arc patch 15937
cd apps/token-server
npm ci
npm test
bytesofman updated this revision to Diff 47004.Wed, Apr 10, 19:39

better comments

Harbormaster completed remote builds in B28454: Diff 47004.Wed, Apr 10, 19:39
bytesofman updated this revision to Diff 47009.Wed, Apr 10, 20:55

rebase

Harbormaster completed remote builds in B28459: Diff 47009.Wed, Apr 10, 20:55
bytesofman updated this revision to Diff 47010.Wed, Apr 10, 21:20

rebase

Harbormaster completed remote builds in B28460: Diff 47010.Wed, Apr 10, 21:22
bytesofman retitled this revision from [token-server] Add methods to build a token reward tx to [token-server] Add method to get token inputs and outputs for a token reward tx.Thu, Apr 11, 00:10
emack accepted this revision.Thu, Apr 11, 00:19
emack added a subscriber: emack.

Accepted with minor nit on function name.

apps/token-server/src/transactions.ts
33 ↗(On Diff #47010)

Isn't this function name a bit too generic for a reward specific function?

64 ↗(On Diff #47010)

hmm this is unfortunate, we should fork it and BigInt the codebase in the near future.

This revision is now accepted and ready to land.Thu, Apr 11, 00:19
bytesofman marked 2 inline comments as done.Thu, Apr 11, 00:23
bytesofman added inline comments.
apps/token-server/src/transactions.ts
33 ↗(On Diff #47010)

well, it would work for any slpv1 token send tx using chronik inputs and this lib.

similar to cashtab -- the function is only general to the scope of this app...but it is pretty general. Will make more sense when we have the other functions, then we call getSlpInputsAndOutputs to get the slp inputs and outputs we need to builda tx.

64 ↗(On Diff #47010)

I have been working on this but it has been tabled during the antd run.

now, it will prob become part of ecash-lib once we get that up and running (then we'll have an ecash-specific stack, schnorr support, the works)

T3504

Closed by commit rABC8afdf5fc8667: [token-server] Add method to get token inputs and outputs for a token reward tx (authored by bytesofman). · Explain WhyThu, Apr 11, 00:24
This revision was automatically updated to reflect the committed changes.
bytesofman marked 2 inline comments as done.
bytesofman added a commit: rABC8afdf5fc8667: [token-server] Add method to get token inputs and outputs for a token reward tx.

Revision Contents
Changeset List

PathSize
apps/
token-server/
30 lines
1 line
src/
95 lines
test/
56 lines
201 lines

Diff 47019

View Options

apps/token-server/package-lock.json

Loading...
View Options

apps/token-server/package.json

Loading...
View Options

apps/token-server/src/transactions.ts

Loading...
View Options

apps/token-server/test/transactions.test.ts

Loading...
View Options

apps/token-server/test/vectors.ts

Loading...