Details

Reviewers

emack

Group Reviewers

Restricted Project

Commits

rABC8afdf5fc8667: [token-server] Add method to get token inputs and outputs for a token reward tx

Summary

Add tested methods for constructing a token rewards tx

Test Plan

npm test

Diff Detail

Repository

rABC Bitcoin ABC

Branch

token-server-wallet-next

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 28451
Build 56443: Build Diff
Build 56442: arc lint + arc unit

Event Timeline

bytesofman created this revision.Apr 10 2024, 17:17

Herald added a reviewer: Restricted Project. · View Herald TranscriptApr 10 2024, 17:17

Harbormaster completed remote builds in B28450: Diff 46999.Apr 10 2024, 17:17

Combine functions, initialize test vector types

Harbormaster completed remote builds in B28451: Diff 47000.Apr 10 2024, 17:57

undo ecash-lib delete

Harbormaster completed remote builds in B28452: Diff 47001.Apr 10 2024, 17:59

add tests

Harbormaster completed remote builds in B28453: Diff 47002.Apr 10 2024, 18:27

publishing despite CI failure as CI issue appears unrelated.

can still be tested with

arc patch 15937
cd apps/token-server
npm ci
npm test

better comments

Harbormaster completed remote builds in B28454: Diff 47004.Apr 10 2024, 19:39

rebase

Harbormaster completed remote builds in B28459: Diff 47009.Apr 10 2024, 20:55

rebase

Harbormaster completed remote builds in B28460: Diff 47010.Apr 10 2024, 21:22

bytesofman retitled this revision from [token-server] Add methods to build a token reward tx to [token-server] Add method to get token inputs and outputs for a token reward tx.Apr 11 2024, 00:10

Accepted with minor nit on function name.

apps/token-server/src/transactions.ts
33 ↗	(On Diff #47010)	Isn't this function name a bit too generic for a reward specific function?
64 ↗	(On Diff #47010)	hmm this is unfortunate, we should fork it and BigInt the codebase in the near future.

This revision is now accepted and ready to land.Apr 11 2024, 00:19

bytesofman marked 2 inline comments as done.Apr 11 2024, 00:23

bytesofman added inline comments.

apps/token-server/src/transactions.ts
33 ↗	(On Diff #47010)	well, it would work for any slpv1 token send tx using chronik inputs and this lib. similar to cashtab -- the function is only general to the scope of this app...but it is pretty general. Will make more sense when we have the other functions, then we call `getSlpInputsAndOutputs` to get the slp inputs and outputs we need to builda tx.
64 ↗	(On Diff #47010)	I have been working on this but it has been tabled during the antd run. now, it will prob become part of `ecash-lib` once we get that up and running (then we'll have an ecash-specific stack, schnorr support, the works) T3504

Closed by commit rABC8afdf5fc8667: [token-server] Add method to get token inputs and outputs for a token reward tx (authored by bytesofman). · Explain WhyApr 11 2024, 00:24

This revision was automatically updated to reflect the committed changes.

bytesofman marked 2 inline comments as done.

bytesofman added a commit: rABC8afdf5fc8667: [token-server] Add method to get token inputs and outputs for a token reward tx.

[token-server] Add method to get token inputs and outputs for a token reward tx
ClosedPublic
Actions

Details

Diff Detail

Event Timeline

Revision Contents
Changeset List

Diff 47000

apps/token-server/package-lock.json

apps/token-server/package.json

apps/token-server/src/transactions.ts

apps/token-server/test/transactions.test.ts

apps/token-server/test/vectors.ts

modules/ecash-lib/.eslintignore

modules/ecash-lib/.gitignore

modules/ecash-lib/.npmignore

modules/ecash-lib/.nycrc

modules/ecash-lib/README.md

modules/ecash-lib/eslint.config.js

modules/ecash-lib/package-lock.json

modules/ecash-lib/package.json

modules/ecash-lib/src/index.ts

modules/ecash-lib/src/io/bytes.test.ts

modules/ecash-lib/src/io/bytes.ts

modules/ecash-lib/src/io/hex.ts

modules/ecash-lib/src/io/int.ts

modules/ecash-lib/src/io/varsize.test.ts

modules/ecash-lib/src/io/varsize.ts

modules/ecash-lib/src/io/writer.ts

modules/ecash-lib/src/io/writerbytes.test.ts

modules/ecash-lib/src/io/writerbytes.ts

modules/ecash-lib/src/io/writerlength.test.ts

modules/ecash-lib/src/io/writerlength.ts

modules/ecash-lib/src/script.test.ts

modules/ecash-lib/src/script.ts

modules/ecash-lib/src/tx.test.ts

modules/ecash-lib/src/tx.ts

modules/ecash-lib/tsconfig.json

[token-server] Add method to get token inputs and outputs for a token reward txClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 47000

apps/token-server/package-lock.json

apps/token-server/package.json

apps/token-server/src/transactions.ts

apps/token-server/test/transactions.test.ts

apps/token-server/test/vectors.ts

modules/ecash-lib/.eslintignore

modules/ecash-lib/.gitignore

modules/ecash-lib/.npmignore

modules/ecash-lib/.nycrc

modules/ecash-lib/README.md

modules/ecash-lib/eslint.config.js

modules/ecash-lib/package-lock.json

modules/ecash-lib/package.json

modules/ecash-lib/src/index.ts

modules/ecash-lib/src/io/bytes.test.ts

modules/ecash-lib/src/io/bytes.ts

modules/ecash-lib/src/io/hex.ts

modules/ecash-lib/src/io/int.ts

modules/ecash-lib/src/io/varsize.test.ts

modules/ecash-lib/src/io/varsize.ts

modules/ecash-lib/src/io/writer.ts

modules/ecash-lib/src/io/writerbytes.test.ts

modules/ecash-lib/src/io/writerbytes.ts

modules/ecash-lib/src/io/writerlength.test.ts

modules/ecash-lib/src/io/writerlength.ts

modules/ecash-lib/src/script.test.ts

modules/ecash-lib/src/script.ts

modules/ecash-lib/src/tx.test.ts

modules/ecash-lib/src/tx.ts

modules/ecash-lib/tsconfig.json

[token-server] Add method to get token inputs and outputs for a token reward tx
ClosedPublic
Actions

Revision Contents
Changeset List