Page MenuHomePhabricator
Differential D1546

Remove BIP9 CSV activation.
ClosedPublic
Actions

Authored by deadalnix on Jul 9 2018, 13:51.

Details

Reviewers
jasonbcox
Group Reviewers
Restricted Project
Commits
rSTAGINGc1ce6b2cbb03: Remove BIP9 CSV activation.
rABCc1ce6b2cbb03: Remove BIP9 CSV activation.
Summary

There is now an activation y height, so it's all good.

Test Plan
make chck
./test/functional/test_runner.py --extended

Updated various tests

Diff Detail

Repository
rABC Bitcoin ABC
Branch
killbip9csv
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 2817
Build 3738: Bitcoin ABC Buildbot (legacy)
Build 3737: arc lint + arc unit

Event Timeline

deadalnix created this revision.Jul 9 2018, 13:51
Herald added a reviewer: Restricted Project. · View Herald TranscriptJul 9 2018, 13:51
teamcity added a subscriber: teamcity.Jul 9 2018, 13:53

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Jul 9 2018, 14:31

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B2817: Diff 4227.Jul 9 2018, 14:31
deadalnix updated this revision to Diff 4231.Jul 9 2018, 14:38

Remove bip9 mention from the getblockchaininfo RPC call

teamcity added a comment.Jul 9 2018, 14:38

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

deadalnix updated this revision to Diff 4233.Jul 9 2018, 14:48

Revert previous update

teamcity added a comment.Jul 9 2018, 14:48

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

deadalnix updated this revision to Diff 4234.Jul 9 2018, 14:51

Actually do what I say I do

teamcity added a comment.Jul 9 2018, 14:53

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Jul 9 2018, 14:54

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing failed.

Harbormaster failed remote builds in B2821: Diff 4233!Jul 9 2018, 14:54
jasonbcox added a subscriber: jasonbcox.Jul 9 2018, 15:03
jasonbcox added inline comments.
test/functional/bip68-112-113-p2p.py
290

Update the comment, since ACTIVE status no longer exists.

teamcity added a comment.Jul 9 2018, 15:17

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B2819: Diff 4231.Jul 9 2018, 15:17
teamcity added a comment.Jul 9 2018, 15:32

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B2822: Diff 4234.Jul 9 2018, 15:32
deadalnix added a child revision: D1550: Remove bip9 from getblockchaininfo RPC call.Jul 9 2018, 16:10
deadalnix added a child revision: D1551: Do not use BIP9 to set block version anymore..Jul 9 2018, 17:07
deadalnix added a child revision: D1553: Remove BIP9 related result and arguments from getblocktemplate.Jul 10 2018, 11:31
deadalnix added a child revision: D1554: Remove warning about block version..Jul 10 2018, 13:18
jasonbcox requested changes to this revision.Jul 10 2018, 14:59
This revision now requires changes to proceed.Jul 10 2018, 14:59
deadalnix updated this revision to Diff 4251.Jul 10 2018, 15:45

Fix comment in test

jasonbcox accepted this revision.Jul 10 2018, 15:46
This revision is now accepted and ready to land.Jul 10 2018, 15:46
teamcity added a comment.Jul 10 2018, 15:46

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Closed by commit rABCc1ce6b2cbb03: Remove BIP9 CSV activation. (authored by deadalnix). · Explain WhyJul 10 2018, 15:49
This revision was automatically updated to reflect the committed changes.
teamcity added a comment.Jul 10 2018, 16:23

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B2833: Diff 4251.Jul 10 2018, 16:23

Revision Contents
Changeset List

PathSize
src/
20 lines
consensus/
2 lines
rpc/
48 lines
4 lines
test/
functional/
86 lines
26 lines
6 lines

Diff 4227

View Options

src/chainparams.cpp

Loading...
View Options

src/consensus/params.h

Loading...
View Options

src/rpc/blockchain.cpp

Loading...
View Options

src/versionbits.cpp

Loading...
View Options

test/functional/bip68-112-113-p2p.py

Loading...
View Options

test/functional/bip68-sequence.py

Loading...
View Options

test/functional/bip9-softforks.py

Loading...
View Options

test/functional/timing.json

Loading...