Page MenuHomePhabricator

Remove BIP9 CSV activation.
ClosedPublic

Authored by deadalnix on Jul 9 2018, 13:51.

Details

Summary

There is now an activation y height, so it's all good.

Test Plan
make chck
./test/functional/test_runner.py --extended

Updated various tests

Diff Detail

Repository
rABC Bitcoin ABC
Branch
killbip9csv
Lint
Lint OK
Unit
No Unit Test Coverage
Build Status
Buildable 2817
Build 3738: Bitcoin ABC Buildbot (legacy)
Build 3737: arc lint + arc unit

Event Timeline

deadalnix created this revision.Jul 9 2018, 13:51
Herald added a reviewer: Restricted Project. · View Herald TranscriptJul 9 2018, 13:51
deadalnix updated this revision to Diff 4231.Jul 9 2018, 14:38

Remove bip9 mention from the getblockchaininfo RPC call

deadalnix updated this revision to Diff 4233.Jul 9 2018, 14:48

Revert previous update

deadalnix updated this revision to Diff 4234.Jul 9 2018, 14:51

Actually do what I say I do

jasonbcox added inline comments.
test/functional/bip68-112-113-p2p.py
290

Update the comment, since ACTIVE status no longer exists.

jasonbcox requested changes to this revision.Jul 10 2018, 14:59
This revision now requires changes to proceed.Jul 10 2018, 14:59
deadalnix updated this revision to Diff 4251.Jul 10 2018, 15:45

Fix comment in test

jasonbcox accepted this revision.Jul 10 2018, 15:46
This revision is now accepted and ready to land.Jul 10 2018, 15:46
This revision was automatically updated to reflect the committed changes.