Details

Reviewers

PiRK

Group Reviewers

Restricted Project

Commits

rABC8cb8e1d99513: [Cashtab] Upgrade slpv1 send txs

Summary

Use upgraded ecash-coinselect to create slpv1 token send txs.

Test Plan

npm test

Diff Detail

Repository

rABC Bitcoin ABC

Branch

slpv1-send-improve

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 27368
Build 54299: Build Diff	cashtab-tests
Build 54298: arc lint + arc unit

Event Timeline

bytesofman created this revision.Feb 23 2024, 00:05

Herald added a reviewer: Restricted Project. · View Herald TranscriptFeb 23 2024, 00:05

Harbormaster completed remote builds in B27336: Diff 45499.Feb 23 2024, 00:08

bytesofman mentioned this in D15520: [ecash-coinselect] Support specified input utxos.Feb 23 2024, 00:13

bytesofman published this revision for review.Feb 23 2024, 00:19

bytesofman added inline comments.

cashtab/package-lock.json
19 ↗	(On Diff #45499)	Note: this is from D15520 Before landing this diff, would publish the version from D15520 and install that Need an npm-hosted version here for CI to work in the diff
cashtab/src/transactions/fixtures/vectors.js
715 ↗	(On Diff #45499)	I reviewed the rawtxs here in Electrum. All looked good and were created at 1 sat/byte, implying expected behavior of `ecash-coinselect` upgrade. I broadcast this last one and it checks out.

bytesofman mentioned this in D15513: [ecash-coinselect] Support for slpv1 token send txs.Feb 23 2024, 00:20

bytesofman mentioned this in D15512: [Cashtab] Upgrade slpv1 send txs.Feb 23 2024, 03:33

remove debug logging

Harbormaster completed remote builds in B27354: Diff 45522.Feb 23 2024, 12:58

bytesofman mentioned this in D15526: [Cashtab] Pass genesis token output with value as int and not string.Feb 23 2024, 14:13

do not parseInt what is already an int

Harbormaster completed remote builds in B27358: Diff 45527.Feb 23 2024, 14:29

PiRK added a subscriber: PiRK.Feb 23 2024, 18:50

PiRK added inline comments.

cashtab/src/components/Send/SendToken.js
186 ↗	(On Diff #45527)	Does this remove all uses of that `sendToken` function? If so, should the function be removed? I don't see any other callsite in the repo.

bytesofman marked an inline comment as done.Feb 23 2024, 18:55

bytesofman added inline comments.

cashtab/src/components/Send/SendToken.js
186 ↗	(On Diff #45527)	Yes -- however, there are so many sub functions and other dependencies in `utils/transactions.js` that I am going to remove them all at once -- after slpBurn is also implemented in this improved method. For example, some of the tx building helpers are used in both send and burn and the respective tests for those legacy functions...so I can't get rid of them yet. I could get rid of just `sendToken`, but doesn't really feel complete, I think easier to keep track of what is being used where if all the legacy functions go at once. I think it will be easier to review that way.

PiRK accepted this revision.Feb 23 2024, 19:16

This revision is now accepted and ready to land.Feb 23 2024, 19:16

bytesofman mentioned this in rABCa3c580ec4238: [ecash-coinselect] Support specified input utxos.Feb 23 2024, 19:33

rebase

found some errors testing with a bunch of slp send txs, checking it out

Harbormaster completed remote builds in B27368: Diff 45540.Feb 23 2024, 20:02

patch error in token send txs with change

This revision is now accepted and ready to land.Feb 23 2024, 20:19

also note to reviewers of these slp diffs -- chronik's preflight checks do prevent accidental token burns in cashtab

cashtab/src/components/Send/SendToken.js
237 ↗	(On Diff #45541)	this works great
236		discovered in testing this didn't render anything

Harbormaster completed remote builds in B27369: Diff 45541.Feb 23 2024, 20:22

Build Bitcoin ABC Diffs / Diff Testing (cashtab-tests) failed.

Failed tests logs:

====== CashTab Unit Tests: Get slpv1 send token inputs and outputs from NNG chronik-client getSendTokenInputs: Legacy unit test of deprecated function generateSendOpReturn ======
Error: expect(received).toStrictEqual(expected) // deep equality

- Expected  - 1
+ Received  + 1

  Array [
-   "49995000",
+   "50000",
    "49945000",
  ]
    at Object.toStrictEqual (/work/cashtab/src/slpv1/__tests__/index.test.js:84:49)
    at Promise.then.completed (/work/cashtab/node_modules/jest-circus/build/utils.js:298:28)
    at new Promise (<anonymous>)
    at callAsyncCircusFn (/work/cashtab/node_modules/jest-circus/build/utils.js:231:10)
    at _callCircusTest (/work/cashtab/node_modules/jest-circus/build/run.js:316:40)
    at processTicksAndRejections (node:internal/process/task_queues:95:5)
    at _runTest (/work/cashtab/node_modules/jest-circus/build/run.js:252:3)
    at _runTestsForDescribeBlock (/work/cashtab/node_modules/jest-circus/build/run.js:126:9)
    at _runTestsForDescribeBlock (/work/cashtab/node_modules/jest-circus/build/run.js:121:9)
    at run (/work/cashtab/node_modules/jest-circus/build/run.js:71:3)
    at runAndTransformResultsToJestFormat (/work/cashtab/node_modules/jest-circus/build/legacy-code-todo-rewrite/jestAdapterInit.js:122:21)
    at jestAdapter (/work/cashtab/node_modules/jest-circus/build/legacy-code-todo-rewrite/jestAdapter.js:79:19)
    at runTestInternal (/work/cashtab/node_modules/jest-runner/build/runTest.js:367:16)
    at runTest (/work/cashtab/node_modules/jest-runner/build/runTest.js:444:34)
    at Object.worker (/work/cashtab/node_modules/jest-runner/build/testWorker.js:106:12)
====== CashTab Unit Tests: Get slpv1 send token inputs and outputs from NNG chronik-client getSendTokenInputs: Token send with change output ======
Error: expect(received).toStrictEqual(expected) // deep equality

- Expected  - 1
+ Received  + 1

  Array [
-   "9999999689",
+   "189",
    "9999999500",
  ]
    at Object.toStrictEqual (/work/cashtab/src/slpv1/__tests__/index.test.js:84:49)
    at Promise.then.completed (/work/cashtab/node_modules/jest-circus/build/utils.js:298:28)
    at new Promise (<anonymous>)
    at callAsyncCircusFn (/work/cashtab/node_modules/jest-circus/build/utils.js:231:10)
    at _callCircusTest (/work/cashtab/node_modules/jest-circus/build/run.js:316:40)
    at processTicksAndRejections (node:internal/process/task_queues:95:5)
    at _runTest (/work/cashtab/node_modules/jest-circus/build/run.js:252:3)
    at _runTestsForDescribeBlock (/work/cashtab/node_modules/jest-circus/build/run.js:126:9)
    at _runTestsForDescribeBlock (/work/cashtab/node_modules/jest-circus/build/run.js:121:9)
    at run (/work/cashtab/node_modules/jest-circus/build/run.js:71:3)
    at runAndTransformResultsToJestFormat (/work/cashtab/node_modules/jest-circus/build/legacy-code-todo-rewrite/jestAdapterInit.js:122:21)
    at jestAdapter (/work/cashtab/node_modules/jest-circus/build/legacy-code-todo-rewrite/jestAdapter.js:79:19)
    at runTestInternal (/work/cashtab/node_modules/jest-runner/build/runTest.js:367:16)
    at runTest (/work/cashtab/node_modules/jest-runner/build/runTest.js:444:34)
    at Object.worker (/work/cashtab/node_modules/jest-runner/build/testWorker.js:106:12)
====== CashTab Unit Tests: Get slpv1 send token inputs and outputs from NNG chronik-client getSendTokenInputs: We ignore un-needed utxos in a token send with change output ======
Error: expect(received).toStrictEqual(expected) // deep equality

- Expected  - 1
+ Received  + 1

  Array [
-   "9999999689",
+   "189",
    "9999999500",
  ]
    at Object.toStrictEqual (/work/cashtab/src/slpv1/__tests__/index.test.js:84:49)
    at Promise.then.completed (/work/cashtab/node_modules/jest-circus/build/utils.js:298:28)
    at new Promise (<anonymous>)
    at callAsyncCircusFn (/work/cashtab/node_modules/jest-circus/build/utils.js:231:10)
    at _callCircusTest (/work/cashtab/node_modules/jest-circus/build/run.js:316:40)
    at processTicksAndRejections (node:internal/process/task_queues:95:5)
    at _runTest (/work/cashtab/node_modules/jest-circus/build/run.js:252:3)
    at _runTestsForDescribeBlock (/work/cashtab/node_modules/jest-circus/build/run.js:126:9)
    at _runTestsForDescribeBlock (/work/cashtab/node_modules/jest-circus/build/run.js:121:9)
    at run (/work/cashtab/node_modules/jest-circus/build/run.js:71:3)
    at runAndTransformResultsToJestFormat (/work/cashtab/node_modules/jest-circus/build/legacy-code-todo-rewrite/jestAdapterInit.js:122:21)
    at jestAdapter (/work/cashtab/node_modules/jest-circus/build/legacy-code-todo-rewrite/jestAdapter.js:79:19)
    at runTestInternal (/work/cashtab/node_modules/jest-runner/build/runTest.js:367:16)
    at runTest (/work/cashtab/node_modules/jest-runner/build/runTest.js:444:34)
    at Object.worker (/work/cashtab/node_modules/jest-runner/build/testWorker.js:106:12)
====== CashTab Unit Tests: Get slpv1 send token inputs and outputs from NNG chronik-client getSendTokenInputs: Token send with change output and decimals ======
Error: expect(received).toStrictEqual(expected) // deep equality

- Expected  - 1
+ Received  + 1

  Array [
-   "212",
+   "210",
    "2",
  ]
    at Object.toStrictEqual (/work/cashtab/src/slpv1/__tests__/index.test.js:84:49)
    at Promise.then.completed (/work/cashtab/node_modules/jest-circus/build/utils.js:298:28)
    at new Promise (<anonymous>)
    at callAsyncCircusFn (/work/cashtab/node_modules/jest-circus/build/utils.js:231:10)
    at _callCircusTest (/work/cashtab/node_modules/jest-circus/build/run.js:316:40)
    at processTicksAndRejections (node:internal/process/task_queues:95:5)
    at _runTest (/work/cashtab/node_modules/jest-circus/build/run.js:252:3)
    at _runTestsForDescribeBlock (/work/cashtab/node_modules/jest-circus/build/run.js:126:9)
    at _runTestsForDescribeBlock (/work/cashtab/node_modules/jest-circus/build/run.js:121:9)
    at run (/work/cashtab/node_modules/jest-circus/build/run.js:71:3)
    at runAndTransformResultsToJestFormat (/work/cashtab/node_modules/jest-circus/build/legacy-code-todo-rewrite/jestAdapterInit.js:122:21)
    at jestAdapter (/work/cashtab/node_modules/jest-circus/build/legacy-code-todo-rewrite/jestAdapter.js:79:19)
    at runTestInternal (/work/cashtab/node_modules/jest-runner/build/runTest.js:367:16)
    at runTest (/work/cashtab/node_modules/jest-runner/build/runTest.js:444:34)
    at Object.worker (/work/cashtab/node_modules/jest-runner/build/testWorker.js:106:12)

Each failure log is accessible here:
CashTab Unit Tests: Get slpv1 send token inputs and outputs from NNG chronik-client getSendTokenInputs: Legacy unit test of deprecated function generateSendOpReturn
CashTab Unit Tests: Get slpv1 send token inputs and outputs from NNG chronik-client getSendTokenInputs: Token send with change output
CashTab Unit Tests: Get slpv1 send token inputs and outputs from NNG chronik-client getSendTokenInputs: We ignore un-needed utxos in a token send with change output
CashTab Unit Tests: Get slpv1 send token inputs and outputs from NNG chronik-client getSendTokenInputs: Token send with change output and decimals

bytesofman planned changes to this revision.Feb 23 2024, 20:23

update vectors for token txs with change

This revision is now accepted and ready to land.Feb 23 2024, 20:27

In D15519#350150, @bytesofman wrote:

found some errors testing with a bunch of slp send txs, checking it out

https://www.youtube.com/watch?v=-u9zr6oF4uA

Harbormaster completed remote builds in B27370: Diff 45544.Feb 23 2024, 20:41

Closed by commit rABC8cb8e1d99513: [Cashtab] Upgrade slpv1 send txs (authored by bytesofman). · Explain WhyFeb 23 2024, 20:55

This revision was automatically updated to reflect the committed changes.

bytesofman added a commit: rABC8cb8e1d99513: [Cashtab] Upgrade slpv1 send txs.

[Cashtab] Upgrade slpv1 send txs
ClosedPublic
Actions

Details

Diff Detail

Event Timeline

Revision Contents
Changeset List

Diff 45540

cashtab/package-lock.json

cashtab/package.json

cashtab/src/components/Send/SendToken.js

cashtab/src/components/Send/tests/SendToken.test.js

cashtab/src/slpv1/tests/index.test.js

cashtab/src/slpv1/fixtures/vectors.js

cashtab/src/slpv1/index.js

cashtab/src/transactions/tests/index.test.js

cashtab/src/transactions/fixtures/mocks.js

cashtab/src/transactions/fixtures/vectors.js

cashtab/src/transactions/index.js

[Cashtab] Upgrade slpv1 send txsClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 45540

cashtab/package-lock.json

cashtab/package.json

cashtab/src/components/Send/SendToken.js

cashtab/src/components/Send/__tests__/SendToken.test.js

cashtab/src/slpv1/__tests__/index.test.js

cashtab/src/slpv1/fixtures/vectors.js

cashtab/src/slpv1/index.js

cashtab/src/transactions/__tests__/index.test.js

cashtab/src/transactions/fixtures/mocks.js

cashtab/src/transactions/fixtures/vectors.js

cashtab/src/transactions/index.js

[Cashtab] Upgrade slpv1 send txs
ClosedPublic
Actions

Revision Contents
Changeset List

cashtab/src/components/Send/tests/SendToken.test.js

cashtab/src/slpv1/tests/index.test.js

cashtab/src/transactions/tests/index.test.js