Differential D15543
[Cashtab] Temporarily mitigate asyc unit test queries occasionally returning unmounted elements Authored by emack on Feb 26 2024, 02:58. Tags None Subscribers None
Details
There is a known issue with react-testing-library that can occasionally result in async queries returning unmounted elements, which results in the following Cashtab test breaking the test suite:  Because this is also affecting unrelated cashtab diff builds, this diff temporarily removes this specific test case while we work on a permanent mitigation. We'll plonk it back posthaste. npm test
Diff Detail
Event TimelineComment Actions this is not the right approach if the test is flaky, it should be fixed if fixing it is impossible for some reason, it should be removed with a note -- prob tho not before an issue is opened with react-testing-library or some kind of effort is in place to fix the situation (but we are certain it will take some time and do not want to halt dev to support) esp in the case of these diffs which impact tx history -- and loading tx history is what depends on rendering the sideshift button, which is the failing test |
