Page MenuHomePhabricator
Differential D15556

[Cashtab] Standardize and improve SendXec.test.js
ClosedPublic
Actions

Authored by bytesofman on Feb 26 2024, 22:00.

Details

Reviewers
emack
Group Reviewers
Restricted Project
Commits
rABCf783b19ddc26: [Cashtab] Standardize and improve SendXec.test.js
Summary

T3444

Apply standardized wrappers and lessons learned to improve SendXec integration tests

Test Plan

npm test

Diff Detail

Repository
rABC Bitcoin ABC
Branch
cashtab-fix-sendxec-tests
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 27439
Build 54441: Build Diffcashtab-tests
Build 54440: arc lint + arc unit

Event Timeline

bytesofman created this revision.Feb 26 2024, 22:00
Herald added a reviewer: Restricted Project. · View Herald TranscriptFeb 26 2024, 22:00
Harbormaster completed remote builds in B27439: Diff 45636.Feb 26 2024, 22:06
bytesofman updated this revision to Diff 45637.Feb 26 2024, 22:25

back out attempted data-testid replacement

bytesofman updated this revision to Diff 45638.Feb 26 2024, 22:25

remove debug logging

bytesofman published this revision for review.Feb 26 2024, 22:26
Harbormaster completed remote builds in B27440: Diff 45637.Feb 26 2024, 22:31
Harbormaster completed remote builds in B27441: Diff 45638.
bytesofman updated this revision to Diff 45656.Feb 27 2024, 00:47

get send button without data-testid

bytesofman added a child revision: D15553: [Cashtab] Calculate max send amount in appropriate way using updated ecash-coinselect.Feb 27 2024, 00:57
Harbormaster completed remote builds in B27457: Diff 45656.Feb 27 2024, 01:06
emack accepted this revision.Feb 27 2024, 08:07
This revision is now accepted and ready to land.Feb 27 2024, 08:07
Closed by commit rABCf783b19ddc26: [Cashtab] Standardize and improve SendXec.test.js (authored by bytesofman). · Explain WhyFeb 27 2024, 12:11
This revision was automatically updated to reflect the committed changes.
bytesofman added a commit: rABCf783b19ddc26: [Cashtab] Standardize and improve SendXec.test.js.
bytesofman removed a child revision: D15553: [Cashtab] Calculate max send amount in appropriate way using updated ecash-coinselect.Feb 27 2024, 12:14

Revision Contents
Changeset List

PathSize
cashtab/
src/
components/
Send/
1 line
__tests__/
925 lines

Diff 45636

View Options

cashtab/src/components/Send/SendXec.js

Loading...
View Options

cashtab/src/components/Send/__tests__/SendXec.test.js

Loading...