Page MenuHomePhabricator

Add CHECKDATASIG opcode.
ClosedPublic

Authored by deadalnix on Jul 14 2018, 12:33.

Details

Summary

The opcode is constantly disabled.

Test Plan

Add test cases to ensure the opcode is disabled.

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Holy shit, script doesn't check for bad opcodes in dead path.

Do not disable the opcode as it also disable it on dead path.

schancel added a subscriber: schancel.
schancel added inline comments.
src/test/monolith_opcodes.cpp
17 ↗(On Diff #4302)

Why did this move?

This revision is now accepted and ready to land.Jul 16 2018, 16:41
src/test/monolith_opcodes.cpp
17 ↗(On Diff #4302)

flagsets needs to be in the test's namespace or we get a definition clash with checkdatasig_tests.cpp

This revision was automatically updated to reflect the committed changes.