Page MenuHomePhabricator
Differential D15634

[guix] unset EMULATE_FHS when not needed
ClosedPublic
Actions

Authored by PiRK on Mar 5 2024, 11:35.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABCc47157a3a05a: [guix] unset EMULATE_FHS when not needed
Summary

Currently we set the var, and it stays set when the next host is reached even if it is *darwin*, which causes the darwin build to fail because the --emulate-fhs option is not compatible with using both gcc-toolchain and clang-toolchain.

Test Plan

Run the MacOS build after any other build:

HOSTS="x86_64-linux-gnu x86_64-apple-darwin"  contrib/guix/guix-build

Diff Detail

Repository
rABC Bitcoin ABC
Branch
guix_stuff
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 27666
Build 54895: Build Diff
Build 54894: arc lint + arc unit

Event Timeline

PiRK created this revision.Mar 5 2024, 11:35
Herald added a reviewer: Restricted Project. · View Herald TranscriptMar 5 2024, 11:35
Harbormaster completed remote builds in B27666: Diff 45926.Mar 5 2024, 11:35
PiRK published this revision for review.Mar 5 2024, 11:46
Fabien accepted this revision.Mar 5 2024, 11:50
This revision is now accepted and ready to land.Mar 5 2024, 11:50
Closed by commit rABCc47157a3a05a: [guix] unset EMULATE_FHS when not needed (authored by PiRK). · Explain WhyMar 5 2024, 13:01
This revision was automatically updated to reflect the committed changes.
PiRK added a commit: rABCc47157a3a05a: [guix] unset EMULATE_FHS when not needed.

Revision Contents
Changeset List

PathSize
contrib/
guix/
1 line

Diff 45926

View Options

contrib/guix/guix-build

Loading...