The antd notification is not properly triggering updates. Also, we want to move alway from antd entirely. Will happen incrementally.
Here is one step.
Details
Details
- Reviewers
PiRK emack - Group Reviewers
Restricted Project - Commits
- rABCc251ec88f62e: [Cashtab] Create custom modal for version upgrades
npm test
How I tested it
- deploy to netlify prod site
- bump the version and deploy it again
- bump the version and deploy it again
clicking ok refreshed the page and updated the version, as expected
clicking 'later' hid the modal and did nothing, as expected
Diff Detail
Diff Detail
- Repository
- rABC Bitcoin ABC
- Branch
- cashtab-modals
- Lint
Lint Errors Severity Location Code Message Error cashtab/src/components/Common/modals.js:16 ESLINT no-unused-vars Error cashtab/src/components/Common/modals.js:16 ESLINT no-unused-vars Error cashtab/src/components/Common/modals.js:17 ESLINT no-unused-vars - Unit
No Test Coverage - Build Status
Buildable 27818 Build 55193: Build Diff cashtab-tests Build 55192: arc lint + arc unit
Event Timeline
Comment Actions
So my steps were:
- Deploy v2.0.10 to netlify
- Create new wallet on there
- Bump version to v2.0.11, then redeploy to netlify
- Waited around with the wallet open but no modal.
- Closed and re-opened browser, upgrade modal shows up on load
- Click OK, cashtab refreshes but Configure.js is still showing v2.0.10
- Hard refresh browser, cashtab now shows v2.0.11
| cashtab/src/components/Common/UpgradeModal.js | ||
|---|---|---|
| 70 ↗ | (On Diff #46146) | Button should be "Update Now" to be more precise. "OK" sounds like you're merely noting the suggestion. |
| cashtab/src/components/Common/UpgradeModal.js | ||
|---|---|---|
| 70 ↗ | (On Diff #46146) |  good point. updated so we only have one primary button. we don't really want "later" to be an attractive option. cancel button is now traditional top right exit. |
