Page MenuHomePhabricator

LoadMempool: Pass in load_path, stop using gArgs
ClosedPublic

Authored by PiRK on Mar 18 2024, 13:44.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABCdc25f8f0ba45: LoadMempool: Pass in load_path, stop using gArgs
Summary

Also:

  1. Have CChainState::LoadMempool and ::ThreadImport take in paths and pass it through untouched to LoadMempool.
  2. Make LoadMempool exit early if the load_path is empty.
  3. Adjust the call to ::ThreadImport in ::AppInitMain to correctly pass in an empty path if mempool persistence is disabled.

This is a partial backport of core#25487
https://github.com/bitcoin/bitcoin/pull/25487/commits/06b88ffb8ae7f2b2a93a32908cd80e77fafd270c

Depends on D15721

Test Plan

ninja all check-all bitcoin-fuzzers

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable