Page MenuHomePhabricator
Differential D15740

validationcaches: Use size_t for sizes
ClosedPublic
Actions

Authored by PiRK on Mar 19 2024, 14:56.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABC3e9bd73fad12: validationcaches: Use size_t for sizes
Summary

...also move the 0-clamping logic to ApplyArgsManOptions, where it belongs.

This concludes backport of core#25527
https://github.com/bitcoin/bitcoin/pull/25527/commits/0f3a2532c38074dd9789d1c4c667db6ca46ff0ab

Depends on D15378

Test Plan

ninja all check-all

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

PiRK created this revision.Mar 19 2024, 14:56
Herald added a reviewer: Restricted Project. · View Herald TranscriptMar 19 2024, 14:56
PiRK requested review of this revision.Mar 19 2024, 14:56
teamcity edited the summary of this revision. (Show Details)Mar 19 2024, 14:56
Harbormaster completed remote builds in B27947: Diff 46308.Mar 19 2024, 14:58
teamcity added a comment.Mar 19 2024, 14:58
Build Bitcoin ABC Diffs / Diff Testing (build-debug) failed.

Tail of the build log:

-- Installing: /results/artifacts/include/secp256k1_preallocated.h
-- Installing: /results/artifacts/include/secp256k1_recovery.h
-- Installing: /results/artifacts/include/secp256k1_schnorr.h
[377/549] Linking C executable src/secp256k1/sign-bench
[378/549] Building CXX object src/wallet/CMakeFiles/wallet.dir/bdb.cpp.o
[379/549] Building CXX object src/wallet/CMakeFiles/wallet.dir/coincontrol.cpp.o
[380/549] Building CXX object src/wallet/CMakeFiles/wallet.dir/context.cpp.o
[381/549] Building CXX object src/wallet/CMakeFiles/wallet-tool.dir/wallettool.cpp.o
[382/549] Linking C executable src/secp256k1/verify-bench
[383/549] Building CXX object src/wallet/CMakeFiles/wallet.dir/coinselection.cpp.o
[384/549] Building CXX object src/test/CMakeFiles/testutil.dir/util/wallet.cpp.o
[385/549] Linking C executable src/secp256k1/ecmult-bench
[386/549] Building CXX object src/test/CMakeFiles/testutil.dir/util/validation.cpp.o
[387/549] Building CXX object src/wallet/CMakeFiles/wallet.dir/crypter.cpp.o
[388/549] Building CXX object src/wallet/CMakeFiles/wallet.dir/db.cpp.o
[389/549] Building CXX object src/wallet/CMakeFiles/wallet.dir/fees.cpp.o
[390/549] Building CXX object src/wallet/CMakeFiles/wallet.dir/load.cpp.o
[391/549] Building CXX object src/wallet/CMakeFiles/wallet.dir/interfaces.cpp.o
[392/549] Building CXX object src/wallet/CMakeFiles/wallet.dir/receive.cpp.o
[393/549] Building CXX object src/wallet/CMakeFiles/wallet.dir/rpc/util.cpp.o
[394/549] Building CXX object src/wallet/CMakeFiles/wallet.dir/rpc/backup.cpp.o
[395/549] Building CXX object src/wallet/CMakeFiles/wallet.dir/salvage.cpp.o
[396/549] Building CXX object src/wallet/CMakeFiles/wallet.dir/rpc/signmessage.cpp.o
[397/549] Building CXX object src/wallet/CMakeFiles/wallet.dir/sqlite.cpp.o
[398/549] Building CXX object src/wallet/CMakeFiles/wallet.dir/rpc/encrypt.cpp.o
[399/549] Building CXX object src/wallet/CMakeFiles/wallet.dir/rpcwallet.cpp.o
[400/549] Building CXX object src/wallet/CMakeFiles/wallet.dir/spend.cpp.o
[401/549] Building CXX object src/wallet/CMakeFiles/wallet.dir/transaction.cpp.o
[402/549] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/db.cpp.o
[403/549] Building CXX object src/wallet/CMakeFiles/wallet.dir/walletutil.cpp.o
[404/549] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/dns.cpp.o
[405/549] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/bitcoin.cpp.o
[406/549] Building CXX object src/wallet/CMakeFiles/wallet.dir/scriptpubkeyman.cpp.o
[407/549] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/options.cpp.o
[408/549] Building CXX object src/seeder/CMakeFiles/bitcoin-seeder.dir/main.cpp.o
[409/549] Building CXX object src/wallet/CMakeFiles/wallet.dir/walletdb.cpp.o
[410/549] Building CXX object src/wallet/CMakeFiles/wallet.dir/wallet.cpp.o
[411/549] Linking CXX static library src/libcommon.a
[412/549] Linking CXX static library src/libscript.a
[413/549] Linking CXX static library src/libbitcoinconsensus.a
[414/549] Linking CXX shared library src/libbitcoinconsensus.so.0.28.11
[415/549] Creating library symlink src/libbitcoinconsensus.so.0 src/libbitcoinconsensus.so
[416/549] Linking CXX executable src/bitcoin-cli
[417/549] Linking CXX executable src/bitcoin-tx
[418/549] Building CXX object src/CMakeFiles/server.dir/node/validation_cache_args.cpp.o
[419/549] Linking CXX static library src/wallet/libwallet.a
[420/549] Building CXX object src/CMakeFiles/server.dir/script/sigcache.cpp.o
FAILED: src/CMakeFiles/server.dir/script/sigcache.cpp.o 
/usr/bin/ccache /usr/bin/c++ -DABORT_ON_FAILED_ASSUME -DBOOST_ALL_NO_LIB -DBUILD_BITCOIN_INTERNAL -DDEBUG -DDEBUG_LOCKORDER -DENABLE_AVX2 -DENABLE_SHANI -DENABLE_SSE41 -DHAVE_BUILD_INFO -DHAVE_CONFIG_H -DHAVE_CONSENSUS_LIB -DLEVELDB_ATOMIC_PRESENT -DLEVELDB_PLATFORM_POSIX -DOS_LINUX -I../../src/leveldb/helpers/memenv -I../../src/. -Isrc -I../../src/univalue/include -Isrc/crypto/.. -I../../src/secp256k1/include -I../../src/leveldb/include -isystem /usr/include/jemalloc -isystem /usr/include/miniupnpc -Werror -O0 -fPIC -fvisibility=hidden -g3 -ftrapv -fstack-reuse=none -fstack-protector-all -Wstack-protector -fcf-protection=full -fstack-clash-protection -U_FORTIFY_SOURCE -Wall -Wextra -Wformat -Wvla -Wcast-align -Wunused-parameter -Wmissing-braces -Wredundant-decls -Wsign-compare -Wduplicated-branches -Wduplicated-cond -Wlogical-op -Wformat-security -Wredundant-move -Woverloaded-virtual -Wno-unused-parameter -Wno-implicit-fallthrough -Wno-psabi -pthread -std=gnu++17 -MD -MT src/CMakeFiles/server.dir/script/sigcache.cpp.o -MF src/CMakeFiles/server.dir/script/sigcache.cpp.o.d -o src/CMakeFiles/server.dir/script/sigcache.cpp.o -c ../../src/script/sigcache.cpp
../../src/script/sigcache.cpp: In function ‘bool InitSignatureCache(size_t)’:
../../src/script/sigcache.cpp:85:12: error: unused variable ‘nMaxCacheSize’ [-Werror=unused-variable]
   85 |     size_t nMaxCacheSize = std::max<int64_t>(max_size_bytes, 0);
      |            ^~~~~~~~~~~~~
cc1plus: all warnings being treated as errors
[421/549] Building CXX object src/CMakeFiles/server.dir/script/scriptcache.cpp.o
[422/549] Building CXX object src/test/CMakeFiles/testutil.dir/util/setup_common.cpp.o
[423/549] Building CXX object src/CMakeFiles/server.dir/init.cpp.o
[424/549] Building CXX object src/CMakeFiles/server.dir/validation.cpp.o
ninja: build stopped: cannot make progress due to previous errors.
Build build-debug failed with exit code 1
teamcity added a comment.Mar 19 2024, 14:58
Build Bitcoin ABC Diffs / Diff Testing (build-clang) failed.

Tail of the build log:

-- Install component: "secp256k1"
-- Installing: /results/artifacts/lib/libsecp256k1.a
-- Installing: /results/artifacts/include/secp256k1.h
-- Installing: /results/artifacts/include/secp256k1_preallocated.h
-- Installing: /results/artifacts/include/secp256k1_recovery.h
-- Installing: /results/artifacts/include/secp256k1_schnorr.h
[379/549] Linking C executable src/secp256k1/recover-bench
[380/549] Building CXX object src/wallet/CMakeFiles/wallet.dir/coincontrol.cpp.o
[381/549] Linking C executable src/secp256k1/ecmult-bench
[382/549] Building CXX object src/wallet/CMakeFiles/wallet.dir/bdb.cpp.o
[383/549] Building CXX object src/wallet/CMakeFiles/wallet.dir/coinselection.cpp.o
[384/549] Building CXX object src/wallet/CMakeFiles/wallet.dir/context.cpp.o
[385/549] Building CXX object src/wallet/CMakeFiles/wallet.dir/db.cpp.o
[386/549] Linking CXX static library src/libcommon.a
[387/549] Building CXX object src/wallet/CMakeFiles/wallet.dir/crypter.cpp.o
[388/549] Linking C executable src/secp256k1/sign-bench
[389/549] Linking C executable src/secp256k1/verify-bench
[390/549] Building CXX object src/wallet/CMakeFiles/wallet.dir/receive.cpp.o
[391/549] Building CXX object src/wallet/CMakeFiles/wallet.dir/fees.cpp.o
[392/549] Building CXX object src/wallet/CMakeFiles/wallet.dir/load.cpp.o
[393/549] Building CXX object src/wallet/CMakeFiles/wallet.dir/interfaces.cpp.o
[394/549] Linking CXX static library src/libscript.a
[395/549] Building CXX object src/wallet/CMakeFiles/wallet.dir/rpc/encrypt.cpp.o
[396/549] Building CXX object src/wallet/CMakeFiles/wallet.dir/rpc/signmessage.cpp.o
[397/549] Building CXX object src/wallet/CMakeFiles/wallet.dir/rpc/backup.cpp.o
[398/549] Building CXX object src/wallet/CMakeFiles/wallet.dir/rpc/util.cpp.o
[399/549] Building CXX object src/wallet/CMakeFiles/wallet.dir/sqlite.cpp.o
[400/549] Building CXX object src/wallet/CMakeFiles/wallet.dir/scriptpubkeyman.cpp.o
[401/549] Building CXX object src/wallet/CMakeFiles/wallet.dir/rpcwallet.cpp.o
[402/549] Building CXX object src/wallet/CMakeFiles/wallet.dir/transaction.cpp.o
[403/549] Building CXX object src/wallet/CMakeFiles/wallet.dir/spend.cpp.o
[404/549] Building CXX object src/wallet/CMakeFiles/wallet.dir/salvage.cpp.o
[405/549] Linking CXX static library src/libbitcoinconsensus.a
[406/549] Building CXX object src/wallet/CMakeFiles/wallet.dir/walletutil.cpp.o
[407/549] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/dns.cpp.o
[408/549] Building CXX object src/wallet/CMakeFiles/wallet.dir/walletdb.cpp.o
[409/549] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/options.cpp.o
[410/549] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/db.cpp.o
[411/549] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/bitcoin.cpp.o
[412/549] Building CXX object src/wallet/CMakeFiles/wallet.dir/wallet.cpp.o
[413/549] Building CXX object src/seeder/CMakeFiles/bitcoin-seeder.dir/main.cpp.o
[414/549] Linking CXX shared library src/libbitcoinconsensus.so.0.28.11
[415/549] Creating library symlink src/libbitcoinconsensus.so.0 src/libbitcoinconsensus.so
[416/549] Linking CXX executable src/bitcoin-cli
[417/549] Linking CXX executable src/bitcoin-tx
[418/549] Linking CXX static library src/wallet/libwallet.a
[419/549] Building CXX object src/CMakeFiles/server.dir/script/sigcache.cpp.o
FAILED: src/CMakeFiles/server.dir/script/sigcache.cpp.o 
/usr/bin/ccache /usr/bin/clang++ -DBOOST_ALL_NO_LIB -DBUILD_BITCOIN_INTERNAL -DENABLE_AVX2 -DENABLE_SHANI -DENABLE_SSE41 -DHAVE_BUILD_INFO -DHAVE_CONFIG_H -DHAVE_CONSENSUS_LIB -DLEVELDB_ATOMIC_PRESENT -DLEVELDB_PLATFORM_POSIX -DOS_LINUX -I../../src/leveldb/helpers/memenv -I../../src/. -Isrc -I../../src/univalue/include -Isrc/crypto/.. -I../../src/secp256k1/include -I../../src/leveldb/include -isystem /usr/include/jemalloc -isystem /usr/include/miniupnpc -Werror -g -O2 -fPIC -fvisibility=hidden -fstack-protector-all -Wstack-protector -fcf-protection=full -fstack-clash-protection -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 -Wall -Wextra -Wformat -Wgnu -Wvla -Wcast-align -Wunused-parameter -Wmissing-braces -Wthread-safety -Wrange-loop-analysis -Wredundant-decls -Wunreachable-code-loop-increment -Wsign-compare -Wconditional-uninitialized -Wdocumentation -Wformat-security -Wredundant-move -Woverloaded-virtual -Wshadow -Wshadow-field -Wno-unused-parameter -Wno-implicit-fallthrough -Wno-psabi -pthread -std=gnu++17 -MD -MT src/CMakeFiles/server.dir/script/sigcache.cpp.o -MF src/CMakeFiles/server.dir/script/sigcache.cpp.o.d -o src/CMakeFiles/server.dir/script/sigcache.cpp.o -c ../../src/script/sigcache.cpp
../../src/script/sigcache.cpp:85:12: error: unused variable 'nMaxCacheSize' [-Werror,-Wunused-variable]
    size_t nMaxCacheSize = std::max<int64_t>(max_size_bytes, 0);
           ^
1 error generated.
[420/549] Building CXX object src/CMakeFiles/server.dir/node/validation_cache_args.cpp.o
[421/549] Building CXX object src/CMakeFiles/server.dir/script/scriptcache.cpp.o
[422/549] Building CXX object src/test/CMakeFiles/testutil.dir/util/setup_common.cpp.o
[423/549] Building CXX object src/CMakeFiles/server.dir/init.cpp.o
[424/549] Building CXX object src/CMakeFiles/server.dir/validation.cpp.o
ninja: build stopped: cannot make progress due to previous errors.
Build build-clang failed with exit code 1
teamcity added a comment.Mar 19 2024, 14:59
Build Bitcoin ABC Diffs / Diff Testing (build-without-wallet) failed.

Tail of the build log:

[462/613] Building CXX object src/CMakeFiles/bitcoinconsensus.dir/arith_uint256.cpp.o
[463/613] Building CXX object src/CMakeFiles/bitcoinconsensus.dir/hash.cpp.o
[464/613] Building CXX object src/CMakeFiles/bitcoinconsensus.dir/primitives/transaction.cpp.o
[465/613] Building CXX object src/CMakeFiles/bitcoinconsensus.dir/pubkey.cpp.o
[466/613] Building CXX object src/CMakeFiles/bitcoinconsensus.dir/uint256.cpp.o
[467/613] Building CXX object src/CMakeFiles/bitcoinconsensus.dir/util/strencodings.cpp.o
[468/613] Building CXX object src/CMakeFiles/bitcoinconsensus.dir/consensus/amount.cpp.o
[469/613] Building CXX object src/CMakeFiles/bitcoinconsensus.dir/consensus/tx_check.cpp.o
[470/613] Building CXX object src/CMakeFiles/bitcoinkernel.dir/txdb.cpp.o
[471/613] Building CXX object src/CMakeFiles/bitcoinconsensus-shared.dir/script/bitcoinconsensus.cpp.o
[472/613] Building CXX object src/CMakeFiles/bitcoinkernel.dir/util/asmap.cpp.o
[473/613] Building C object src/secp256k1/CMakeFiles/secp256k1.dir/src/secp256k1.c.o
[474/613] Linking C static library src/secp256k1/libsecp256k1.a
[475/613] Linking CXX static library src/libbitcoinconsensus.a
[476/613] Building CXX object src/CMakeFiles/server.dir/net_processing.cpp.o
[477/613] Building C object src/secp256k1/CMakeFiles/recover-bench.dir/src/bench_recover.c.o
[478/613] Linking C executable src/secp256k1/recover-bench
[479/613] Building C object src/secp256k1/CMakeFiles/ecmult-bench.dir/src/bench_ecmult.c.o
[480/613] Linking CXX static library src/libscript.a
[481/613] Linking C executable src/secp256k1/ecmult-bench
[482/613] Building C object src/secp256k1/CMakeFiles/verify-bench.dir/src/bench_verify.c.o
[483/613] Linking C executable src/secp256k1/verify-bench
[484/613] Building C object src/secp256k1/CMakeFiles/sign-bench.dir/src/bench_sign.c.o
[485/613] Linking C executable src/secp256k1/sign-bench
[486/613] Building C object src/secp256k1/CMakeFiles/internal-bench.dir/src/bench_internal.c.o
[487/613] Linking CXX static library src/libcommon.a
[488/613] Linking C executable src/secp256k1/internal-bench
[489/613] Building CXX object src/CMakeFiles/bitcoinkernel.dir/avalanche/proof.cpp.o
[490/613] Linking CXX shared library src/libbitcoinconsensus.so.0.28.11
[491/613] Creating library symlink src/libbitcoinconsensus.so.0 src/libbitcoinconsensus.so
[492/613] Building CXX object src/test/CMakeFiles/testutil.dir/util/blockindex.cpp.o
[493/613] Linking CXX executable src/bitcoin-cli
[494/613] Building CXX object src/test/CMakeFiles/testutil.dir/util/logging.cpp.o
[495/613] Building CXX object src/CMakeFiles/bitcoinkernel.dir/avalanche/proofpool.cpp.o
[496/613] Building CXX object src/CMakeFiles/bitcoind.dir/bitcoind.cpp.o
[497/613] Building CXX object src/test/CMakeFiles/testutil.dir/util/str.cpp.o
[498/613] Building CXX object src/test/CMakeFiles/testutil.dir/util/transaction_utils.cpp.o
[499/613] Building CXX object src/CMakeFiles/bitcoinkernel.dir/txmempool.cpp.o
[500/613] Building CXX object src/test/CMakeFiles/testutil.dir/util/wallet.cpp.o
[501/613] Building CXX object src/CMakeFiles/bitcoinkernel.dir/policy/block/stakingrewards.cpp.o
[502/613] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/db.cpp.o
[503/613] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/dns.cpp.o
[504/613] Building CXX object src/CMakeFiles/bitcoin-chainstate.dir/bitcoin-chainstate.cpp.o
[505/613] Building CXX object src/CMakeFiles/server.dir/validation.cpp.o
[506/613] Building CXX object src/test/CMakeFiles/testutil.dir/util/blockfilter.cpp.o
[507/613] Building CXX object src/CMakeFiles/bitcoinkernel.dir/avalanche/peermanager.cpp.o
[508/613] Building CXX object src/CMakeFiles/bitcoin-tx.dir/bitcoin-tx.cpp.o
[509/613] Building CXX object src/test/CMakeFiles/testutil.dir/util/net.cpp.o
[510/613] Linking CXX executable src/bitcoin-tx
[511/613] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/options.cpp.o
[512/613] Building CXX object src/test/CMakeFiles/testutil.dir/util/mining.cpp.o
[513/613] Building CXX object src/CMakeFiles/bitcoinkernel.dir/avalanche/processor.cpp.o
[514/613] Building CXX object src/test/CMakeFiles/testutil.dir/util/validation.cpp.o
[515/613] Building CXX object src/seeder/CMakeFiles/bitcoin-seeder.dir/main.cpp.o
[516/613] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/bitcoin.cpp.o
[517/613] Building CXX object src/test/CMakeFiles/testutil.dir/util/setup_common.cpp.o
[518/613] Building CXX object src/CMakeFiles/bitcoinkernel.dir/net.cpp.o
[519/613] Building CXX object src/CMakeFiles/bitcoinkernel.dir/validation.cpp.o
ninja: build stopped: cannot make progress due to previous errors.
Build build-without-wallet failed with exit code 1
teamcity added a comment.Mar 19 2024, 14:59
Build Bitcoin ABC Diffs / Diff Testing (build-diff) failed.

Tail of the build log:

[367/549] Building C object src/secp256k1/CMakeFiles/sign-bench.dir/src/bench_sign.c.o
[368/549] Linking C executable src/secp256k1/sign-bench
[369/549] Linking CXX shared library src/libbitcoinconsensus.so.0.28.11
[370/549] Creating library symlink src/libbitcoinconsensus.so.0 src/libbitcoinconsensus.so
[371/549] Building CXX object src/test/CMakeFiles/testutil.dir/util/blockindex.cpp.o
[372/549] Building CXX object src/test/CMakeFiles/testutil.dir/util/logging.cpp.o
[373/549] Building CXX object src/CMakeFiles/server.dir/rpc/avalanche.cpp.o
[374/549] Building CXX object src/CMakeFiles/server.dir/init.cpp.o
[375/549] Building CXX object src/CMakeFiles/server.dir/torcontrol.cpp.o
[376/549] Building CXX object src/test/CMakeFiles/testutil.dir/util/str.cpp.o
[377/549] Building CXX object src/test/CMakeFiles/testutil.dir/util/transaction_utils.cpp.o
[378/549] Building CXX object src/CMakeFiles/server.dir/rpc/net.cpp.o
[379/549] Building CXX object src/test/CMakeFiles/testutil.dir/util/blockfilter.cpp.o
[380/549] Building CXX object src/CMakeFiles/server.dir/txmempool.cpp.o
[381/549] Building CXX object src/CMakeFiles/bitcoin-cli.dir/bitcoin-cli.cpp.o
[382/549] Linking CXX executable src/bitcoin-cli
[383/549] Building CXX object src/wallet/CMakeFiles/wallet.dir/coincontrol.cpp.o
[384/549] Building CXX object src/wallet/CMakeFiles/wallet.dir/coinselection.cpp.o
[385/549] Building CXX object src/wallet/CMakeFiles/wallet.dir/context.cpp.o
[386/549] Building CXX object src/wallet/CMakeFiles/wallet.dir/crypter.cpp.o
[387/549] Building CXX object src/test/CMakeFiles/testutil.dir/util/validation.cpp.o
[388/549] Building CXX object src/test/CMakeFiles/testutil.dir/util/net.cpp.o
[389/549] Building CXX object src/test/CMakeFiles/testutil.dir/util/mining.cpp.o
[390/549] Building CXX object src/CMakeFiles/bitcoin-tx.dir/bitcoin-tx.cpp.o
[391/549] Building CXX object src/CMakeFiles/server.dir/wallet/init.cpp.o
[392/549] Linking CXX executable src/bitcoin-tx
[393/549] Building CXX object src/wallet/CMakeFiles/wallet.dir/db.cpp.o
[394/549] Building CXX object src/test/CMakeFiles/testutil.dir/util/wallet.cpp.o
[395/549] Building CXX object src/CMakeFiles/server.dir/rpc/rawtransaction.cpp.o
[396/549] Building CXX object src/CMakeFiles/server.dir/rpc/blockchain.cpp.o
[397/549] Building CXX object src/test/CMakeFiles/testutil.dir/util/setup_common.cpp.o
[398/549] Building CXX object src/wallet/CMakeFiles/wallet.dir/bdb.cpp.o
[399/549] Building CXX object src/wallet/CMakeFiles/wallet.dir/fees.cpp.o
[400/549] Building CXX object src/CMakeFiles/server.dir/net_processing.cpp.o
[401/549] Building CXX object src/wallet/CMakeFiles/wallet.dir/load.cpp.o
[402/549] Building CXX object src/wallet/CMakeFiles/wallet.dir/transaction.cpp.o
[403/549] Building CXX object src/wallet/CMakeFiles/wallet-tool.dir/wallettool.cpp.o
[404/549] Building CXX object src/wallet/CMakeFiles/wallet.dir/receive.cpp.o
[405/549] Building CXX object src/wallet/CMakeFiles/wallet.dir/walletutil.cpp.o
[406/549] Building CXX object src/wallet/CMakeFiles/wallet.dir/rpc/util.cpp.o
[407/549] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/db.cpp.o
[408/549] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/dns.cpp.o
[409/549] Building CXX object src/wallet/CMakeFiles/wallet.dir/sqlite.cpp.o
[410/549] Building CXX object src/wallet/CMakeFiles/wallet.dir/rpc/signmessage.cpp.o
[411/549] Building CXX object src/wallet/CMakeFiles/wallet.dir/rpc/encrypt.cpp.o
[412/549] Building CXX object src/wallet/CMakeFiles/wallet.dir/salvage.cpp.o
[413/549] Building CXX object src/wallet/CMakeFiles/wallet.dir/interfaces.cpp.o
[414/549] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/options.cpp.o
[415/549] Building CXX object src/CMakeFiles/server.dir/validation.cpp.o
[416/549] Building CXX object src/wallet/CMakeFiles/wallet.dir/spend.cpp.o
[417/549] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/bitcoin.cpp.o
[418/549] Building CXX object src/seeder/CMakeFiles/bitcoin-seeder.dir/main.cpp.o
[419/549] Building CXX object src/wallet/CMakeFiles/wallet.dir/scriptpubkeyman.cpp.o
[420/549] Building CXX object src/wallet/CMakeFiles/wallet.dir/walletdb.cpp.o
[421/549] Building CXX object src/wallet/CMakeFiles/wallet.dir/rpc/backup.cpp.o
[422/549] Building CXX object src/wallet/CMakeFiles/wallet.dir/wallet.cpp.o
[423/549] Building CXX object src/wallet/CMakeFiles/wallet.dir/rpcwallet.cpp.o
[424/549] Linking CXX static library src/wallet/libwallet.a
ninja: build stopped: cannot make progress due to previous errors.
Build build-diff failed with exit code 1
PiRK planned changes to this revision.Mar 19 2024, 15:01

?!

PiRK updated this revision to Diff 46309.Mar 19 2024, 15:04

remove unused line

Harbormaster completed remote builds in B27948: Diff 46309.Mar 19 2024, 15:24
Fabien accepted this revision.Mar 19 2024, 19:52
This revision is now accepted and ready to land.Mar 19 2024, 19:52
Closed by commit rABC3e9bd73fad12: validationcaches: Use size_t for sizes (authored by Carl Dong <contact@carldong.me>, committed by PiRK). · Explain WhyMar 20 2024, 07:17
This revision was automatically updated to reflect the committed changes.
PiRK added a commit: rABC3e9bd73fad12: validationcaches: Use size_t for sizes.

Revision Contents
Changeset List

PathSize
src/
2 lines
kernel/
6 lines
node/
12 lines
script/
2 lines
7 lines
2 lines
8 lines

Diff 46317

View Options

src/cuckoocache.h

Loading...
View Options

src/kernel/validation_cache_sizes.h

Loading...
View Options

src/node/validation_cache_args.cpp

Loading...
View Options

src/script/scriptcache.h

Loading...
View Options

src/script/scriptcache.cpp

Loading...
View Options

src/script/sigcache.h

Loading...
View Options

src/script/sigcache.cpp

Loading...