Page MenuHomePhabricator

cleanup more unused code after removal of chained-tx logic (TestLockPointValidity)
ClosedPublic

Authored by PiRK on Mar 27 2024, 09:18.

Details

Summary

TestLockPointValidity is unused since D13133. Remove it, and remove include for GetConsensus that is no longer used.

LockPoint::maxInputBlock is no longer used by anything, TestLockPointValidity was the only user. We no longer need to compute it in validation and we can remove it from the struct.
As a result we longer need to include chain.h (CBlockIndex).

Test Plan

ninja all check-all

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

PiRK requested review of this revision.Mar 27 2024, 09:18
PiRK retitled this revision from cleanup more unused code after removal of chained-tx logic to cleanup more unused code after removal of chained-tx logic (TestLockPointValidity).Mar 27 2024, 09:27
This revision is now accepted and ready to land.Mar 27 2024, 14:11