cleanup more unused code after removal of chained-tx logic (TestLockPointValidity)
ClosedPublic
Actions

Authored by PiRK on Mar 27 2024, 09:18.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rABC6b9dd55f580a: cleanup more unused code after removal of chained-tx logic…

Summary

TestLockPointValidity is unused since D13133. Remove it, and remove include for GetConsensus that is no longer used.

LockPoint::maxInputBlock is no longer used by anything, TestLockPointValidity was the only user. We no longer need to compute it in validation and we can remove it from the struct.
As a result we longer need to include chain.h (CBlockIndex).

Test Plan

ninja all check-all

Diff Detail

Repository

rABC Bitcoin ABC

Branch

master

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 28083
Build 55711: Build Diff	build-debug · build-clang · build-diff · build-without-wallet · lint-circular-dependencies · build-clang-tidy
Build 55710: arc lint + arc unit

Event Timeline

PiRK created this revision.Mar 27 2024, 09:18

Herald added a reviewer: Restricted Project. · View Herald TranscriptMar 27 2024, 09:18

PiRK requested review of this revision.Mar 27 2024, 09:18

PiRK edited the summary of this revision. (Show Details)Mar 27 2024, 09:24

PiRK retitled this revision from cleanup more unused code after removal of chained-tx logic to cleanup more unused code after removal of chained-tx logic (TestLockPointValidity).Mar 27 2024, 09:27

Harbormaster completed remote builds in B28083: Diff 46497.Mar 27 2024, 09:37

PiRK added a child revision: D15789: remove coinbase spend tracking in CTxMemPoolEntry.Mar 27 2024, 09:58

Fabien accepted this revision.Mar 27 2024, 14:11

This revision is now accepted and ready to land.Mar 27 2024, 14:11

Closed by commit rABC6b9dd55f580a: cleanup more unused code after removal of chained-tx logic… (authored by PiRK). · Explain WhyMar 27 2024, 15:52

This revision was automatically updated to reflect the committed changes.

PiRK added a commit: rABC6b9dd55f580a: cleanup more unused code after removal of chained-tx logic….

PiRK mentioned this in D16104: refactor: Move calculation logic out from `CheckSequenceLocksAtTip()`.May 3 2024, 13:45

PiRK mentioned this in rABC22f5560fd2f6: refactor: Move calculation logic out from `CheckSequenceLocksAtTip()`.May 6 2024, 11:54