Paths

Table of Contentst

Differential D15789

remove coinbase spend tracking in CTxMemPoolEntry
ClosedPublic
Actions

Authored by PiRK on Mar 27 2024, 09:58.

Tags

None

Subscribers

None

Details

Reviewers

Group Reviewers

Restricted Project

Commits

rABC5f461d35eff6: remove coinbase spend tracking in CTxMemPoolEntry

Summary

Tracking of coinbase spends in CTxMemPoolEntry was introduced in https://github.com/bitcoin/bitcoin/pull/6915/commits/7e49f5f8b4e237d7212d027a7bea4bbd52c9e7b6
After removing removeForReorg in D13133, a lot of the code that previously cared about whether a mempool tx spends a coinbase no longer does.

Coinbase maturity is still checked via MemPoolAccept::PreChecks -> Consensus::CheckTxInputs.

Depends on D15788

Test Plan

ninja all check-all bench-bitcoin

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

PiRK created this revision.Mar 27 2024, 09:58

Herald added a reviewer: Restricted Project. · View Herald TranscriptMar 27 2024, 09:58

PiRK published this revision for review.Mar 27 2024, 09:59

PiRK edited the test plan for this revision. (Show Details)

PiRK retitled this revision from emove coinbase spend tracking in CTxMemPoolEntry to remove coinbase spend tracking in CTxMemPoolEntry.

Harbormaster completed remote builds in B28084: Diff 46498.Mar 27 2024, 10:17

PiRK added a child revision: D15790: Move CTxMemPoolEntry class to its own module and inline class's function.Mar 27 2024, 10:56

Fabien accepted this revision.Mar 27 2024, 14:13

This revision is now accepted and ready to land.Mar 27 2024, 14:13

Closed by commit rABC5f461d35eff6: remove coinbase spend tracking in CTxMemPoolEntry (authored by PiRK). · Explain WhyMar 27 2024, 15:52

This revision was automatically updated to reflect the committed changes.

PiRK added a commit: rABC5f461d35eff6: remove coinbase spend tracking in CTxMemPoolEntry.

Revision Contents
Changeset List

Path

Size

src/

bench/

10 lines

mempool_eviction.cpp

5 lines

mempool_stress.cpp

5 lines

rpc_mempool.cpp

1 line

test/

miner_tests.cpp

82 lines

util/

8 lines

setup_common.cpp

7 lines

12 lines

7 lines

13 lines

Diff 46508

src/bench/chained_tx.cpp

Loading...

src/bench/mempool_eviction.cpp

Loading...

src/bench/mempool_stress.cpp

Loading...

src/bench/rpc_mempool.cpp

Loading...

src/test/miner_tests.cpp

Loading...

src/test/util/setup_common.h

Loading...

src/test/util/setup_common.cpp

Loading...

src/txmempool.h

Loading...

src/txmempool.cpp

Loading...

src/validation.cpp

Loading...