Differential D15791

[avalanche] Account for network propagation time for staking rewards
ClosedPublic
Actions

Authored by Fabien on Mar 27 2024, 13:44.

Tags

None

Subscribers

Details

Reviewers

Group Reviewers

Restricted Project

Commits

rABCc4052f2947c0: [avalanche] Account for network propagation time for staking rewards

Summary

There is a delay before a proof can be selected for staking rewards, which can cause discrepeancy due to the proof propagation/registration time. To avoid this we allow for an additional winner if the proof is in a recent registration time range. This does not change the winner selected by the miner.

Test Plan

ninja check-all

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

Fabien created this revision.Mar 27 2024, 13:44

Herald added a reviewer: Restricted Project. · View Herald TranscriptMar 27 2024, 13:44

Harbormaster completed remote builds in B28087: Diff 46502.Mar 27 2024, 14:41

Fabien added a child revision: D15842: [avalanche] Increase the delay for a proof to be eligible to staking rewards.Apr 1 2024, 15:44

I followed through the logic, and it seems good to me.

Fabien published this revision for review.Apr 3 2024, 08:13

PiRK accepted this revision.Apr 3 2024, 08:14

This revision is now accepted and ready to land.Apr 3 2024, 08:14

Closed by commit rABCc4052f2947c0: [avalanche] Account for network propagation time for staking rewards (authored by Fabien). · Explain WhyApr 3 2024, 08:17

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABCc4052f2947c0: [avalanche] Account for network propagation time for staking rewards.

Revision Contents
Changeset List

Path

Size

src/

avalanche/

peermanager.cpp

12 lines

test/

peermanager_tests.cpp

44 lines

Diff 46761

src/avalanche/peermanager.cpp

Loading...

src/avalanche/test/peermanager_tests.cpp

Loading...