Paths

Table of Contentst

Differential D15796

get config via chainstatemanager when possible (1/n)
ClosedPublic
Actions

Authored by PiRK on Mar 28 2024, 08:39.

Tags

None

Subscribers

None

Details

Reviewers

Group Reviewers

Restricted Project

Commits

rABCbd69d55d4624: get config via chainstatemanager when possible (1/n)

Summary

This removes the need for passing config as a function argument through the whole validation stack, when a reference is already available via ChainstateManager.options.

In this diff we apply this idea to AcceptToMemoryPool, ProcessNewPackages and ConnectTip (and to the whole stake of functions that needed a Config for the only purpose calling these 3)

There are more places where this can be applied, but I noticed the diff is starting to get big, so let's do the rest in separate diffs.

Test Plan

ninja all check-all

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

PiRK created this revision.Mar 28 2024, 08:39

Herald added a reviewer: Restricted Project. · View Herald TranscriptMar 28 2024, 08:39

PiRK requested review of this revision.Mar 28 2024, 08:39

PiRK edited the summary of this revision. (Show Details)Mar 28 2024, 08:49

Harbormaster completed remote builds in B28110: Diff 46531.Mar 28 2024, 08:57

PiRK added a parent revision: D15795: refactor: move *index constants out of validation.Thu, Mar 28, 09:37

PiRK added a child revision: D15797: get config via chainstatemanager when possible (2/n).Thu, Mar 28, 09:38

Fabien accepted this revision.Thu, Mar 28, 12:08

This revision is now accepted and ready to land.Thu, Mar 28, 12:08

Closed by commit rABCbd69d55d4624: get config via chainstatemanager when possible (1/n) (authored by PiRK). · Explain WhyThu, Mar 28, 13:02

This revision was automatically updated to reflect the committed changes.

PiRK added a commit: rABCbd69d55d4624: get config via chainstatemanager when possible (1/n).

Revision Contents
Changeset List

Path

Size

src/

avalanche/

test/

peermanager_tests.cpp

3 lines

processor_tests.cpp

4 lines

bench/

17 lines

bitcoin-chainstate.cpp

2 lines

kernel/

disconnected_transactions.h

3 lines

disconnected_transactions.cpp

6 lines

mempool_persist.h

5 lines

mempool_persist.cpp

7 lines

net_processing.cpp

7 lines

node/

blockstorage.cpp

4 lines

rpc/

11 lines

rawtransaction.cpp

2 lines

test/

fuzz/

validation_load_mempool.cpp

3 lines

txpackage_tests.cpp

25 lines

util/

3 lines

setup_common.cpp

5 lines

validation_chainstate_tests.cpp

2 lines

validation_chainstatemanager_tests.cpp

2 lines

26 lines

69 lines

Diff 46539

src/avalanche/test/peermanager_tests.cpp

Loading...

src/avalanche/test/processor_tests.cpp

Loading...

src/bench/chained_tx.cpp

Loading...

src/bitcoin-chainstate.cpp

Loading...

src/kernel/disconnected_transactions.h

Loading...

src/kernel/disconnected_transactions.cpp

Loading...

src/kernel/mempool_persist.h

Loading...

src/kernel/mempool_persist.cpp

Loading...

src/net_processing.cpp

Loading...

src/node/blockstorage.cpp

Loading...

src/rpc/blockchain.cpp

Loading...

src/rpc/rawtransaction.cpp

Loading...

src/test/fuzz/validation_load_mempool.cpp

Loading...

src/test/txpackage_tests.cpp

Loading...

src/test/util/chainstate.h

Loading...

src/test/util/setup_common.cpp

Loading...

src/test/validation_chainstate_tests.cpp

Loading...

src/test/validation_chainstatemanager_tests.cpp

Loading...

src/validation.h

Loading...

src/validation.cpp

Loading...