Paths

Table of Contentst

Differential D15797

get config via chainstatemanager when possible (2/n)
ClosedPublic
Actions

Authored by PiRK on Mar 28 2024, 09:38.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rABC665bf5b1ec44: get config via chainstatemanager when possible (2/n)

Summary

In this diff we remove the unused config parameter from UnwindBlock and its callers.

Depends on D15796

Test Plan

ninja all check-all

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

PiRK created this revision.Mar 28 2024, 09:38

Herald added a reviewer: Restricted Project. · View Herald TranscriptMar 28 2024, 09:38

PiRK requested review of this revision.Mar 28 2024, 09:38

PiRK added a child revision: D15798: get config via chainstatemanager when possible (3/n).

Harbormaster completed remote builds in B28111: Diff 46532.Mar 28 2024, 09:57

Fabien accepted this revision.Thu, Mar 28, 12:10

This revision is now accepted and ready to land.Thu, Mar 28, 12:10

Closed by commit rABC665bf5b1ec44: get config via chainstatemanager when possible (2/n) (authored by PiRK). · Explain WhyThu, Mar 28, 13:02

This revision was automatically updated to reflect the committed changes.

PiRK added a commit: rABC665bf5b1ec44: get config via chainstatemanager when possible (2/n).

PiRK mentioned this in D15799: fix chronikbridge_tests.Thu, Mar 28, 13:50

PiRK mentioned this in rABCf9248cd296c8: fix chronikbridge_tests.Thu, Mar 28, 14:39

Revision Contents
Changeset List

Path

Size

src/

avalanche/

test/

peermanager_tests.cpp

6 lines

processor_tests.cpp

3 lines

bench/

chained_tx.cpp

2 lines

net_processing.cpp

3 lines

rpc/

blockchain.cpp

5 lines

test/

interfaces_tests.cpp

2 lines

validation.h

20 lines

validation.cpp

14 lines

Diff 46540

View Options

src/avalanche/test/peermanager_tests.cpp

View Options

src/avalanche/test/processor_tests.cpp

View Options

src/bench/chained_tx.cpp

View Options

src/net_processing.cpp

View Options

src/rpc/blockchain.cpp

View Options

src/test/interfaces_tests.cpp

View Options

src/validation.h

View Options

get config via chainstatemanager when possible (2/n)ClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 46540

src/avalanche/test/peermanager_tests.cpp

src/avalanche/test/processor_tests.cpp

src/bench/chained_tx.cpp

src/net_processing.cpp

src/rpc/blockchain.cpp

src/test/interfaces_tests.cpp

src/validation.h

src/validation.cpp

get config via chainstatemanager when possible (2/n)
ClosedPublic
Actions

Revision Contents
Changeset List