Page MenuHomePhabricator

Moved rpc/server.h/cpp to rpc/helpers.h/cpp
AbandonedPublic

Authored by jasonbcox on Jul 22 2018, 22:01.

Details

Reviewers
deadalnix
schancel
Group Reviewers
Restricted Project
Summary

Moving server.h/cpp for two reasons:

  1. There is no server class in server.h, so the name is inaccurate.
  2. I want to create an RPCServer class and use server.h as a plain header

without all of this existing garbage in it.

I know the "helpers" name is kind of lame, but it will need to be split up into separate
header files in the near future as the RPC refactor continues.

Depends on D1583.

Test Plan

make check

Diff Detail

Repository
rABC Bitcoin ABC
Branch
rpchelpers
Lint
Lint Passed
SeverityLocationCodeMessage
Auto-Fixsrc/httprpc.cpp:1CFMTCode style violation
Unit
No Test Coverage
Build Status
Buildable 2917
Build 3938: Bitcoin ABC Buildbot (legacy)
Build 3937: arc lint + arc unit

Event Timeline

Might abandon this revision after talking with Amaury regarding this design. Rather than moving everything to helpers, he recommends building up the new RPCServer API first such that RPCServer calls the legacy RPC functions, and then slowly migrate legacy code out to various headers or delete them as necessary.