Page MenuHomePhabricator
Differential D1588

Moved JSONRPCRequest to its own header
ClosedPublic
Actions

Authored by jasonbcox on Jul 23 2018, 23:33.

Details

Reviewers
deadalnix
schancel
Group Reviewers
Restricted Project
Commits
rSTAGING76e69cd1d176: Moved JSONRPCRequest to its own header
rABC76e69cd1d176: Moved JSONRPCRequest to its own header
Summary

Need to move this class for upcoming RPC diffs in addition to locating it in its own separate header like it should be.

Test Plan

make check

Diff Detail

Repository
rABC Bitcoin ABC
Branch
jsonrpcreq
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 2953
Build 4006: Bitcoin ABC Buildbot (legacy)
Build 4005: arc lint + arc unit

Event Timeline

jasonbcox created this revision.Jul 23 2018, 23:33
Herald added a reviewer: Restricted Project. · View Herald TranscriptJul 23 2018, 23:33
teamcity added a subscriber: teamcity.Jul 23 2018, 23:35

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Jul 24 2018, 00:15

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing failed.

Harbormaster failed remote builds in B2922: Diff 4381!Jul 24 2018, 00:15
deadalnix accepted this revision.Jul 25 2018, 15:53
deadalnix added inline comments.
src/rpc/jsonrpcrequest.cpp
1 ↗(On Diff #4381)

Please add the usual blurb.

This revision is now accepted and ready to land.Jul 25 2018, 15:53
deadalnix added inline comments.Jul 25 2018, 15:54
src/rpc/server.cpp
16 ↗(On Diff #4381)

Maybe some of these can be cleaned up ?

jasonbcox added inline comments.Jul 25 2018, 18:27
src/rpc/server.cpp
16 ↗(On Diff #4381)

Yes. I tried doing that in another branch, but it proved to be more involved than just simply removing them. I'll be looking to clean these up in the future as I clean up this and the header file.

jasonbcox updated this revision to Diff 4416.Jul 25 2018, 18:29

Added copyright comments

teamcity added a comment.Jul 25 2018, 18:37

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Jul 25 2018, 19:13

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B2953: Diff 4416.Jul 25 2018, 19:13
Closed by commit rABC76e69cd1d176: Moved JSONRPCRequest to its own header (authored by jasonbcox). · Explain WhyJul 25 2018, 19:15
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
1 line
2 lines
rpc/
30 lines
47 lines
19 lines
36 lines

Diff 4416

View Options

src/CMakeLists.txt

Loading...
View Options

src/Makefile.am

Loading...
View Options

src/rpc/jsonrpcrequest.h

Loading...
View Options

src/rpc/jsonrpcrequest.cpp

Loading...
View Options

src/rpc/server.h

Loading...
View Options

src/rpc/server.cpp

Loading...