Paths

Table of Contentst

Differential D15905

Remove unused CDataStream methods
ClosedPublic
Actions

Authored by PiRK on Apr 5 2024, 13:29.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rABC30f5fdfc2a99: Remove unused CDataStream methods

Summary

This is a follow-up to D14689: change the callsites that use CDataStream::operator+= so that it can be removed.
This makes future backports related to streams.h easier.

This completes backport of core#20464
https://github.com/bitcoin/bitcoin/pull/20464/commits/faa96f841fe45bc49ebb6e07ac82a129fa9c40bf

Depends on D15903

Test Plan

ninja check check-seeder

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

PiRK created this revision.Apr 5 2024, 13:29

Herald added a reviewer: Restricted Project. · View Herald TranscriptApr 5 2024, 13:29

PiRK requested review of this revision.Apr 5 2024, 13:29

teamcity edited the summary of this revision. (Show Details)Apr 5 2024, 13:29

PiRK edited the summary of this revision. (Show Details)Apr 5 2024, 13:30

PiRK added a parent revision: D15903: Generalize/simplify VectorReader into SpanReader.

Harbormaster completed remote builds in B28349: Diff 46869.Apr 5 2024, 14:02

Fabien accepted this revision.Apr 5 2024, 18:08

This revision is now accepted and ready to land.Apr 5 2024, 18:08

Closed by commit rABC30f5fdfc2a99: Remove unused CDataStream methods (authored by PiRK). · Explain WhyApr 8 2024, 15:10

This revision was automatically updated to reflect the committed changes.

PiRK added a commit: rABC30f5fdfc2a99: Remove unused CDataStream methods.

Revision Contents
Changeset List

Path

Size

src/

seeder/

test/

message_writer_tests.cpp

6 lines

streams.h

5 lines

Diff 46950

View Options

src/seeder/test/message_writer_tests.cpp